Re: [PATCH] mm/vmstat: retrieve more accurate vmstat value

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Joonsoo Kim <iamjoonsoo.kim@lge.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] mm/vmstat: retrieve more accurate vmstat value
Date	Thu, 03 Dec 2015 05:20:01 +0100
Message-ID	<qBtx7-8sd-3@gated-at.bofh.it> (permalink)
References	<qyfh0-4q8-7@gated-at.bofh.it> <qynRj-1yb-103@gated-at.bofh.it> <qyytk-8pA-13@gated-at.bofh.it> <qyKNS-9k-71@gated-at.bofh.it> <qyU0N-5R8-1@gated-at.bofh.it>
X-Original-To	Christoph Lameter <cl@linux.com>
X-Original-Senderip	156.147.1.121
X-Original-Mailfrom	iamjoonsoo.kim@lge.com
X-Original-Senderip	10.177.222.138
X-Original-Mailfrom	iamjoonsoo.kim@lge.com
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.21 (2010-09-15)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	39
Organization	linux.* mail to news gateway
X-Original-Cc	Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org, linux-mm@kvack.org
X-Original-Date	Thu, 3 Dec 2015 13:14:11 +0900
X-Original-Message-ID	<20151203041410.GA1495@js1304-P5Q-DELUXE>
X-Original-References	<1448346123-2699-1-git-send-email-iamjoonsoo.kim@lge.com> <alpine.DEB.2.20.1511240934130.20512@east.gentwo.org> <20151125025735.GC9563@js1304-P5Q-DELUXE> <alpine.DEB.2.20.1511251002380.31590@east.gentwo.org> <20151126015252.GA13138@js1304-P5Q-DELUXE>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1282689

Show key headers only | View raw

On Thu, Nov 26, 2015 at 10:52:52AM +0900, Joonsoo Kim wrote:
> On Wed, Nov 25, 2015 at 10:04:44AM -0600, Christoph Lameter wrote:
> > > Although vmstat values aren't designed for accuracy, these are already
> > > used by some sensitive places so it is better to be more accurate.
> > 
> > The design is to sacrifice accuracy and the time the updates occur for
> > performance reasons. This is not the purpose the counters were designed
> > for. If you put these demands on the vmstat then you will get complex
> > convoluted code and compromise performance.
> 
> I understand design decision, but, it is better to get value as much
> as accurate if there is no performance problem. My patch would not
> cause much performance degradation because it is just adding one
> this_cpu_read().
> 
> Consider about following example. Current implementation returns
> interesting output if someone do following things.
> 
> v1 = zone_page_state(XXX);
> mod_zone_page_state(XXX, 1);
> v2 = zone_page_state(XXX);
> 
> v2 would be same with v1 in most of cases even if we already update
> it.
> 
> This situation could occurs in page allocation path and others. If
> some task try to allocate many pages, then watermark check returns
> same values until updating vmstat even if some freepage are allocated.
> There are some adjustments for this imprecision but why not do it become
> accurate? I think that this change is reasonable trade-off.
> 
Christoph, any comment?

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] mm/vmstat: retrieve more accurate vmstat value Joonsoo Kim <iamjoonsoo.kim@lge.com> - 2015-12-03 05:20 +0100

csiph-web