Re: [PATCH 0/2] Two fix for dwc2 gadget driver

Path	csiph.com!au2pb.net!feeder.erje.net!2.eu.feeder.erje.net!nntpspool01.opticnetworks.net!aioe.org!bofh.it!news.nic.it!robomod
From	John Youn <John.Youn@synopsys.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 0/2] Two fix for dwc2 gadget driver
Date	Thu, 03 Dec 2015 02:30:02 +0100
Message-ID	<qBqSC-6Bi-7@gated-at.bofh.it> (permalink)
References	<qApce-7Pn-5@gated-at.bofh.it>
X-Original-To	"changbin.du@intel.com" <changbin.du@intel.com>, "John.Youn@synopsys.com" <John.Youn@synopsys.com>
Thread-Topic	[PATCH 0/2] Two fix for dwc2 gadget driver
Thread-Index	AQHRKzAM2hGgodsEV0a0esy9gDFZRg==
Accept-Language	en-US
Content-Language	en-US
X-Originating-IP	[10.9.139.127]
Content-Type	text/plain; charset="us-ascii"
Content-Transfer-Encoding	8BIT
MIME-Version	1.0
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	35
Organization	linux.* mail to news gateway
X-Original-Cc	"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>, "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "balbi@ti.com" <balbi@ti.com>
X-Original-Date	Thu, 3 Dec 2015 01:20:56 +0000
X-Original-Message-ID	<2B3535C5ECE8B5419E3ECBE30077290901DC3ED679@US01WEMBX2.internal.synopsys.com>
X-Original-References	<1448860888-9841-1-git-send-email-changbin.du@intel.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1282634

Show key headers only | View raw

On 11/29/2015 9:29 PM, changbin.du@intel.com wrote:
> From: "Du, Changbin" <changbin.du@intel.com>
> 
> With the first patch, enable a enabled ep will return -EBUSY.
> The second patch forbid queuing on disabled ep to avoid panic.


The usb_ep->enabled flag was added in 4.4.

It looks like these same checks are also added at the API level in the
usb_ep_enable() and usb_ep_disable().

In case this is bypassed we should probably add them in the gadget
anyways but using the existing flag.

Regards,
John



> 
> Du, Changbin (2):
>   usb: dwc2: add ep enabled flag to avoid double enable/disable
>   usb: dwc2: forbid queuing request to a disabled ep
> 
>  drivers/usb/dwc2/core.h   |  1 +
>  drivers/usb/dwc2/gadget.c | 26 +++++++++++++++++++++++++-
>  2 files changed, 26 insertions(+), 1 deletion(-)
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 0/2] Two fix for dwc2 gadget driver John Youn <John.Youn@synopsys.com> - 2015-12-03 02:30 +0100
  RE: [PATCH 0/2] Two fix for dwc2 gadget driver "Du, Changbin" <changbin.du@intel.com> - 2015-12-03 05:30 +0100
    [PATCH] usb: gadget: forbid queuing request to a disabled ep changbin.du@intel.com - 2015-12-04 08:30 +0100
      Re: [PATCH] usb: gadget: forbid queuing request to a disabled ep Felipe Balbi <balbi@ti.com> - 2015-12-10 18:30 +0100

csiph-web