Re: [PATCH] mtd: brcmnand: Workaround false ECC uncorrectable errors

From	Simon Arlott <simon@fire.lp0.eu>
Newsgroups	linux.kernel
Subject	Re: [PATCH] mtd: brcmnand: Workaround false ECC uncorrectable errors
Date	2015-12-02 22:40 +0100
Message-ID	<qBni2-4hS-25@gated-at.bofh.it> (permalink)
References	(1 earlier) <qAQFs-8sH-33@gated-at.bofh.it> <qBm2C-3zv-1@gated-at.bofh.it> <qBmvD-3Jz-13@gated-at.bofh.it> <qBmFk-3Od-15@gated-at.bofh.it> <qBmP1-47N-29@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 02/12/15 21:08, Jonas Gorski wrote:
> On Wed, Dec 2, 2015 at 9:54 PM, Brian Norris
> <computersforpeace@gmail.com> wrote:
>>
>> BTW, I think Kamal had code to handle protecting bitflips in erased
>> pages code in the Broadcom STB Linux BSP. Perhaps he can port that to
>> upstream with nand_check_erased_ecc_chunk()? IIUC, that would probably
>> handle your case too, Simon, although it wouldn't be optimal for an
>> all-0xff check (i.e., bitflip_threshold == 0).
>>
>> If that's really an issue (i.e., we have an implementation + data), I'm
>> sure we could add optimization to nand_check_erased_ecc_chunk() to
>> support the bitflip_threshold == 0 case.
> 
> Maybe I'm missing something, but wasn't the point of introducing
> nand_check_erased_ecc_chunk that bitflips in erased pages should be
> treated as bitflips corrected by the ecc, and therefore fixed up
> before passing the data further on? So having a theshold of 0 would be
> wrong / no protection at all, and could be quite destructive on MLC
> nand, where bitflips in erased pages are rather common.

Without this patch I can't access erased pages at all. I don't know if
the controller will still return an uncorrectable error if the page is
erased but has 1 or more bit flips.

-- 
Simon Arlott
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

Re: [PATCH] mtd: brcmnand: Workaround false ECC uncorrectable errors Jonas Gorski <jogo@openwrt.org> - 2015-12-01 11:50 +0100
  Re: [PATCH] mtd: brcmnand: Workaround false ECC uncorrectable errors Simon Arlott <simon@fire.lp0.eu> - 2015-12-02 21:20 +0100
    Re: [PATCH] mtd: brcmnand: Workaround false ECC uncorrectable errors Jonas Gorski <jogo@openwrt.org> - 2015-12-02 21:50 +0100
      Re: [PATCH] mtd: brcmnand: Workaround false ECC uncorrectable errors Brian Norris <computersforpeace@gmail.com> - 2015-12-02 22:00 +0100
        Re: [PATCH] mtd: brcmnand: Workaround false ECC uncorrectable errors Brian Norris <computersforpeace@gmail.com> - 2015-12-02 22:10 +0100
        Re: [PATCH] mtd: brcmnand: Workaround false ECC uncorrectable errors Jonas Gorski <jogo@openwrt.org> - 2015-12-02 22:10 +0100
          Re: [PATCH] mtd: brcmnand: Workaround false ECC uncorrectable errors Simon Arlott <simon@fire.lp0.eu> - 2015-12-02 22:40 +0100
          Re: [PATCH] mtd: brcmnand: Workaround false ECC uncorrectable errors Brian Norris <computersforpeace@gmail.com> - 2015-12-02 23:30 +0100

csiph-web