Re: [PATCH v2] usb: ehci: ohci: use true/false for bool

From	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] usb: ehci: ohci: use true/false for bool
Date	2015-12-02 23:20 +0100
Message-ID	<qBnUK-4LF-9@gated-at.bofh.it> (permalink)
References	<qBnL4-4Iv-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Dec 02, 2015 at 07:09:19PM -0300, Geyslan G. Bem wrote:
> When declaring/initializing bool use true instead of 1. If it's false,
> there's no need to explicit initialize it, once it's default.
> 
> Caught by coccinelle.
> 
> Signed-off-by: Geyslan G. Bem <geyslan@gmail.com>
> ---
>  drivers/usb/host/ehci-hcd.c | 2 +-
>  drivers/usb/host/ohci-hcd.c | 4 ++--
>  drivers/usb/host/u132-hcd.c | 2 +-
>  3 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-hcd.c
> index 48c92bf..1b01967 100644
> --- a/drivers/usb/host/ehci-hcd.c
> +++ b/drivers/usb/host/ehci-hcd.c
> @@ -98,7 +98,7 @@ module_param (park, uint, S_IRUGO);
>  MODULE_PARM_DESC (park, "park setting; 1-3 back-to-back async packets");
>  
>  /* for flakey hardware, ignore overcurrent indicators */
> -static bool ignore_oc = 0;
> +static bool ignore_oc;

This should be a separate patch as it's doing something differently than
what you describe.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH v2] usb: ehci: ohci: use true/false for bool "Geyslan G. Bem" <geyslan@gmail.com> - 2015-12-02 23:10 +0100
  Re: [PATCH v2] usb: ehci: ohci: use true/false for bool Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2015-12-02 23:20 +0100
    Re: [PATCH v2] usb: ehci: ohci: use true/false for bool "Geyslan G. Bem" <geyslan@gmail.com> - 2015-12-02 23:30 +0100
      Re: [PATCH v2] usb: ehci: ohci: use true/false for bool "Geyslan G. Bem" <geyslan@gmail.com> - 2015-12-03 00:30 +0100

csiph-web