Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1282248

Re: [PATCH v3 14/19] irqchip/mips-gic: Use gic_vpes instead of NR_CPUS

Show all headers | View raw

Hello.

On 12/02/2015 03:21 PM, Qais Yousef wrote:

> NR_CPUS is set by Kconfig and could be much higher than what actually is in the
> system.
>
> gic_vpes should be a true representitives of the number of cpus in the system,
> so use it instead.
>
> Signed-off-by: Qais Yousef <qais.yousef@imgtec.com>
> ---
>   drivers/irqchip/irq-mips-gic.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/irqchip/irq-mips-gic.c b/drivers/irqchip/irq-mips-gic.c
> index 41ccc84c68ba..c24feb739bb3 100644
> --- a/drivers/irqchip/irq-mips-gic.c
> +++ b/drivers/irqchip/irq-mips-gic.c
[...]
> @@ -1084,7 +1084,7 @@ static void __init __gic_init(unsigned long gic_base_addr,
>   	gic_ipi_domain->bus_token = DOMAIN_BUS_IPI;
>
>   	/* Make the last 2 * NR_CPUS available for IPIs */

    Looks like you forgot to also change this comment...

> -	bitmap_set(ipi_resrv, gic_shared_intrs - 2 * NR_CPUS, 2 * NR_CPUS);
> +	bitmap_set(ipi_resrv, gic_shared_intrs - 2 * gic_vpes, 2 * gic_vpes);
>
>   	gic_basic_init();
>

MBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 14/19] irqchip/mips-gic: Use gic_vpes instead of NR_CPUS Qais Yousef <qais.yousef@imgtec.com> - 2015-12-02 13:30 +0100
  Re: [PATCH v3 14/19] irqchip/mips-gic: Use gic_vpes instead of  NR_CPUS Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2015-12-02 19:30 +0100
    Re: [PATCH v3 14/19] irqchip/mips-gic: Use gic_vpes instead of  NR_CPUS Qais Yousef <qais.yousef@imgtec.com> - 2015-12-03 11:00 +0100

csiph-web