Re: [PATCH] block: add calls to split trace point

From	Mike Krinkin <krinkin.m.u@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] block: add calls to split trace point
Date	2015-12-02 20:10 +0100
Message-ID	<qBkWS-2Tg-25@gated-at.bofh.it> (permalink)
References	<qvTDY-m1-19@gated-at.bofh.it> <qwbAR-3W1-5@gated-at.bofh.it> <qBaXv-4EG-7@gated-at.bofh.it> <qBj4M-1FO-65@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Dec 02, 2015 at 10:06:09AM -0700, Jens Axboe wrote:
> On 12/02/2015 01:25 AM, Mike Krinkin wrote:
> >Hi Jens,
> >
> >i would like to check status of the patch, will the patch be applied?
> >
> 
> Why aren't you just putting the split trace call into blk_queue_split()?

Do you mean after split? Something like this:

	if (split) {
		/* there isn't chance to merge the splitted bio */
		split->bi_rw |= REQ_NOMERGE;

		bio_chain(split, *bio);
		trace_block_split(q, split, bio->bi_iter.bi_sector);
		generic_make_request(*bio);
		*bio = split;
	}

block_split trace event docs says that it expects "bio being split", i
understood it as "bio before split". But scarcely someone depends on
this behaviour, so i'll resend the patch, is it ok?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH] block: add calls to split trace point Mike Krinkin <krinkin.m.u@gmail.com> - 2015-12-02 09:30 +0100
  Re: [PATCH] block: add calls to split trace point Jens Axboe <axboe@kernel.dk> - 2015-12-02 18:10 +0100
    Re: [PATCH] block: add calls to split trace point Mike Krinkin <krinkin.m.u@gmail.com> - 2015-12-02 20:10 +0100

csiph-web