Groups > linux.kernel > #1281956

Re: [PATCH 10/10] ARM: dts: Fix dm814x pinctrl address and mask

From	Tony Lindgren <tony@atomide.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 10/10] ARM: dts: Fix dm814x pinctrl address and mask
Date	2015-12-02 17:20 +0100
Message-ID	<qBiim-161-9@gated-at.bofh.it> (permalink)
References	<qB2GC-7Ot-3@gated-at.bofh.it> <qB2GC-7Ot-5@gated-at.bofh.it> <qB3t0-8kJ-15@gated-at.bofh.it> <qB3Ml-8rf-1@gated-at.bofh.it> <qB4p3-ui-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

* Matthijs van Duin <matthijsvanduin@gmail.com> [151201 17:23]:
> On 2 December 2015 at 01:46, Tony Lindgren <tony@atomide.com> wrote:
> > We should probably have separate PIN_INPUT_3V3 and PIN_OUTPUT_3V3
> > dts macros that ensure that?
> 
> I'm in general no fan of such macros: it feels really awkward to have
> to make that distinction in dts when doing pin config.
> 
> Note that if you're feeling really enthausiastic about putting in
> effort to allow inputs to be disabled while staying clear of the
> erratum, I think you can detect at runtime which I/O supplies are 3.3V
> by inspecting this register:
> 
> #define CTRL_CQDETECT_STATUS    0x48140e00

OK and if really needed needed the SoC revision information can be
passed to pinctrl-singl.c in it's platform_data that we already have
in addition to the dts configuration. And then pinctrl-single.c could
modify the mask based on IO voltage and SoC revision.

I think we're already covered as the boards can override the pinctrl
function-mask in the board specific dts file if really needed :)

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 10/10] ARM: dts: Fix dm814x pinctrl address and mask Tony Lindgren <tony@atomide.com> - 2015-12-02 00:40 +0100
  Re: [PATCH 10/10] ARM: dts: Fix dm814x pinctrl address and mask Matthijs van Duin <matthijsvanduin@gmail.com> - 2015-12-02 01:30 +0100
    Re: [PATCH 10/10] ARM: dts: Fix dm814x pinctrl address and mask Tony Lindgren <tony@atomide.com> - 2015-12-02 01:50 +0100
      Re: [PATCH 10/10] ARM: dts: Fix dm814x pinctrl address and mask Matthijs van Duin <matthijsvanduin@gmail.com> - 2015-12-02 02:20 +0100
        Re: [PATCH 10/10] ARM: dts: Fix dm814x pinctrl address and mask Tony Lindgren <tony@atomide.com> - 2015-12-02 02:30 +0100
          Re: [PATCH 10/10] ARM: dts: Fix dm814x pinctrl address and mask Tony Lindgren <tony@atomide.com> - 2015-12-02 17:20 +0100
      Re: [PATCH 10/10] ARM: dts: Fix dm814x pinctrl address and mask Matthijs van Duin <matthijsvanduin@gmail.com> - 2015-12-02 02:30 +0100
        Re: [PATCH 10/10] ARM: dts: Fix dm814x pinctrl address and mask Tony Lindgren <tony@atomide.com> - 2015-12-02 17:20 +0100

csiph-web