Groups > linux.kernel > #1281998

[PATCH 2/3] regulator: wm831x-dcdc: Use platform_register/unregister_drivers()

Path	csiph.com!usenet.pasdenom.info!aioe.org!bofh.it!news.nic.it!robomod
From	Thierry Reding <thierry.reding@gmail.com>
Newsgroups	linux.kernel
Subject	[PATCH 2/3] regulator: wm831x-dcdc: Use platform_register/unregister_drivers()
Date	Wed, 02 Dec 2015 17:40:03 +0100
Message-ID	<qBiBJ-1dB-25@gated-at.bofh.it> (permalink)
References	<qBiBJ-1dB-27@gated-at.bofh.it>
X-Original-To	Mark Brown <broonie@kernel.org>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=B8+RbTp02roauz408PVguKmIGLnCHsPkEJ2MLIkZ7zc=; b=JwPcqbYXPm6jd5M1qoDt8XA71dgQuMf0PDw3tKSBHcvFD2y0HHRNj+kh26Isbfiejn 5NcikQmD6OBYMUw7fQYxfOzIUU1lIAIeh/08rqA/B8YzhH33nN7QCgTTMkZ7WLUGVh2m hqR/gCFk9AGQ+t0Uf6wEml0SlVUJmP9tiwouYuAW5uuU8Z8GSpD3dRkDrNzg9Ne6JXch hLZfw4ZNrtHgbFLtzDoArOelhaG2Kc4yu1+fjbY5QcP2F+4oKYwPkxytQ/LZnUO6O8vX epoe7Iwt+tX/gkQreylpqx3ol91f1S8nRHE5fpnG8CySM/Lal27qbtEAPzYRXNaoKDZ7 ZVBw==
X-Received	by 10.194.110.5 with SMTP id hw5mr6721630wjb.154.1449073976611; Wed, 02 Dec 2015 08:32:56 -0800 (PST)
X-Mailer	git-send-email 2.5.0
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	68
Organization	linux.* mail to news gateway
X-Original-Cc	linux-kernel@vger.kernel.org
X-Original-Date	Wed, 2 Dec 2015 17:32:52 +0100
X-Original-Message-ID	<1449073973-12863-2-git-send-email-thierry.reding@gmail.com>
X-Original-References	<1449073973-12863-1-git-send-email-thierry.reding@gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1281998

Show key headers only | View raw

From: Thierry Reding <treding@nvidia.com>

These new helpers simplify implementing multi-driver modules and
properly handle failure to register one driver by unregistering all
previously registered drivers.

Signed-off-by: Thierry Reding <treding@nvidia.com>
---
 drivers/regulator/wm831x-dcdc.c | 31 +++++++++----------------------
 1 file changed, 9 insertions(+), 22 deletions(-)

diff --git a/drivers/regulator/wm831x-dcdc.c b/drivers/regulator/wm831x-dcdc.c
index 8cbb82ceec40..05f69d1ede19 100644
--- a/drivers/regulator/wm831x-dcdc.c
+++ b/drivers/regulator/wm831x-dcdc.c
@@ -884,35 +884,22 @@ static struct platform_driver wm831x_epe_driver = {
 	},
 };
 
+static struct platform_driver * const drivers[] = {
+	&wm831x_buckv_driver,
+	&wm831x_buckp_driver,
+	&wm831x_boostp_driver,
+	&wm831x_epe_driver,
+};
+
 static int __init wm831x_dcdc_init(void)
 {
-	int ret;
-	ret = platform_driver_register(&wm831x_buckv_driver);
-	if (ret != 0)
-		pr_err("Failed to register WM831x BUCKV driver: %d\n", ret);
-
-	ret = platform_driver_register(&wm831x_buckp_driver);
-	if (ret != 0)
-		pr_err("Failed to register WM831x BUCKP driver: %d\n", ret);
-
-	ret = platform_driver_register(&wm831x_boostp_driver);
-	if (ret != 0)
-		pr_err("Failed to register WM831x BOOST driver: %d\n", ret);
-
-	ret = platform_driver_register(&wm831x_epe_driver);
-	if (ret != 0)
-		pr_err("Failed to register WM831x EPE driver: %d\n", ret);
-
-	return 0;
+	return platform_register_drivers(drivers, ARRAY_SIZE(drivers));
 }
 subsys_initcall(wm831x_dcdc_init);
 
 static void __exit wm831x_dcdc_exit(void)
 {
-	platform_driver_unregister(&wm831x_epe_driver);
-	platform_driver_unregister(&wm831x_boostp_driver);
-	platform_driver_unregister(&wm831x_buckp_driver);
-	platform_driver_unregister(&wm831x_buckv_driver);
+	platform_unregister_drivers(drivers, ARRAY_SIZE(drivers));
 }
 module_exit(wm831x_dcdc_exit);
 
-- 
2.5.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 2/3] regulator: wm831x-dcdc: Use platform_register/unregister_drivers() Thierry Reding <thierry.reding@gmail.com> - 2015-12-02 17:40 +0100
  Applied "regulator: wm831x-dcdc: Use platform_register/unregister_drivers()" to the regulator tree Mark Brown <broonie@kernel.org> - 2015-12-02 21:20 +0100

csiph-web