Groups > linux.kernel > #1281906

Re: [PATCH] ftrace: Remove use of control list and ops

From	Jiri Olsa <jolsa@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] ftrace: Remove use of control list and ops
Date	2015-12-02 16:30 +0100
Message-ID	<qBhvZ-xy-29@gated-at.bofh.it> (permalink)
References	(4 earlier) <qAWrx-3Jy-21@gated-at.bofh.it> <qBbqy-4Qy-7@gated-at.bofh.it> <qBgzU-8k6-25@gated-at.bofh.it> <qBh2X-8un-27@gated-at.bofh.it> <qBhcC-nj-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Dec 02, 2015 at 10:03:46AM -0500, Steven Rostedt wrote:
> On Wed, 2 Dec 2015 15:50:32 +0100
> Jiri Olsa <jolsa@redhat.com> wrote:
> 
> > On Wed, Dec 02, 2015 at 09:27:00AM -0500, Steven Rostedt wrote:
> > > On Wed, 2 Dec 2015 09:58:26 +0100
> > > Jiri Olsa <jolsa@redhat.com> wrote:
> > >   
> > > > On Tue, Dec 01, 2015 at 11:56:55AM -0500, Steven Rostedt wrote:
> > > > 
> > > > SNIP
> > > >   
> > > > > -static void ftrace_ops_recurs_func(unsigned long ip, unsigned long parent_ip,
> > > > > +static void ftrace_ops_assist_func(unsigned long ip, unsigned long parent_ip,
> > > > >  				   struct ftrace_ops *op, struct pt_regs *regs)
> > > > >  {
> > > > >  	int bit;
> > > > >  
> > > > > +	if ((op->flags & FTRACE_OPS_FL_RCU) && !rcu_is_watching())
> > > > > +		return;
> > > > > +
> > > > >  	bit = trace_test_and_set_recursion(TRACE_LIST_START, TRACE_LIST_MAX);
> > > > >  	if (bit < 0)
> > > > >  		return;
> > > > >  
> > > > > -	op->func(ip, parent_ip, op, regs);
> > > > > +	preempt_disable_notrace();
> > > > >  
> > > > > +	if (!(op->flags & FTRACE_OPS_FL_PER_CPU) ||
> > > > > +	    ftrace_function_local_disabled(op)) {    
> > > > 
> > > > should be !ftrace_function_local_disabled(op) in here,
> > > > I passed my test with attached patch
> > > >   
> > > 
> > > Can you retest with this patch:  
> > 
> > sure, but other than the declaration removal it's the same change
> > 
> 
> Yep, but I'm paranoid :-) Any change I like to get retested. But if
> you're fine, can I get a 'Tested-by' from you?

yep, I re-tested ;-)

Tested-by: Jiri Olsa <jolsa@kernel.org>

thanks,
jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] ftrace: Remove use of control list and ops Steven Rostedt <rostedt@goodmis.org> - 2015-11-30 23:40 +0100
  Re: [PATCH] ftrace: Remove use of control list and ops Jiri Olsa <jolsa@redhat.com> - 2015-12-01 14:50 +0100
    Re: [PATCH] ftrace: Remove use of control list and ops Steven Rostedt <rostedt@goodmis.org> - 2015-12-01 16:00 +0100
      Re: [PATCH] ftrace: Remove use of control list and ops Jiri Olsa <jolsa@redhat.com> - 2015-12-01 17:00 +0100
        Re: [PATCH] ftrace: Remove use of control list and ops Steven Rostedt <rostedt@goodmis.org> - 2015-12-01 18:00 +0100
          Re: [PATCH] ftrace: Remove use of control list and ops Jiri Olsa <jolsa@redhat.com> - 2015-12-02 09:00 +0100
            Re: [PATCH] ftrace: Remove use of control list and ops Steven Rostedt <rostedt@goodmis.org> - 2015-12-02 15:20 +0100
          Re: [PATCH] ftrace: Remove use of control list and ops Jiri Olsa <jolsa@redhat.com> - 2015-12-02 10:00 +0100
            Re: [PATCH] ftrace: Remove use of control list and ops Steven Rostedt <rostedt@goodmis.org> - 2015-12-02 15:30 +0100
              Re: [PATCH] ftrace: Remove use of control list and ops Jiri Olsa <jolsa@redhat.com> - 2015-12-02 16:00 +0100
                Re: [PATCH] ftrace: Remove use of control list and ops Steven Rostedt <rostedt@goodmis.org> - 2015-12-02 16:10 +0100
                Re: [PATCH] ftrace: Remove use of control list and ops Jiri Olsa <jolsa@redhat.com> - 2015-12-02 16:30 +0100

csiph-web