Re: [PATCH 21/40] staging: lustre: improve LNet clean up code and API

From	Dan Carpenter <dan.carpenter@oracle.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 21/40] staging: lustre: improve LNet clean up code and API
Date	2015-12-02 14:10 +0100
Message-ID	<qBfkt-7B5-13@gated-at.bofh.it> (permalink)
References	<qx3rz-5CJ-5@gated-at.bofh.it> <qx3Bg-5Gz-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Actually we're going to have to redo so much code that it's not worth it
for me to review the rest of these patches.  Please just look over
everything again:

 BAD:	return -1;
GOOD:	return -EINVAL;

 BAD:  failed0:
GOOD:  free_something:

 BAD:	if (rc != 0)
GOOD:	if (rc)

Do one thing per patch.
Do not introduce a bug and then fix it in a later patch.
Check ioc_len more carefully.
Don't make the code look ugly just to please checkpatch.pl.
Do error handling not success handling.
Try to avoid indenting a far to the right.


regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 21/40] staging: lustre: improve LNet clean up code and API Dan Carpenter <dan.carpenter@oracle.com> - 2015-12-02 14:10 +0100
  Re: [lustre-devel] [PATCH 21/40] staging: lustre: improve LNet clean  up code and API Alexander Zarochentsev <alexander.zarochentsev@seagate.com> - 2015-12-02 15:00 +0100
    Re: [lustre-devel] [PATCH 21/40] staging: lustre: improve LNet clean  up code and API Dan Carpenter <dan.carpenter@oracle.com> - 2015-12-02 15:10 +0100

csiph-web