Re: [PATCH] mac80211_hwsim: missing NULL check

From	Johannes Berg <johannes@sipsolutions.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH] mac80211_hwsim: missing NULL check
Date	2015-12-02 11:00 +0100
Message-ID	<qBcmB-5tS-7@gated-at.bofh.it> (permalink)
References	<qAqUF-tv-9@gated-at.bofh.it> <qBcmB-5tS-9@gated-at.bofh.it> <qAqUF-tv-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, 2015-11-30 at 12:46 +0530, Rahul Jain wrote:
> From: Amit Khatri <amit.khatri@samsung.com>
> 
> txrate variable might be NULL and passing inside function
> without NULL check.

Applied. However, this comes with a big BUT.

I seems to always be rewriting your static checker patches, or asking
for clarification, rewording, etc.

Please: review what I did to this commit, and in the future please
submit patches that actually describe what's going on, what you're
doing, and why you're doing it.

IOW, analyse the code and don't just do the minimum necessary to shut
up the static checker. Doing that is fairly much useless, especially in
really obscure cases like this.

I'm going to drop further patches like this one without warning.

johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] mac80211_hwsim: missing NULL check Johannes Berg <johannes@sipsolutions.net> - 2015-12-02 11:00 +0100

csiph-web