Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1281592

[RESEND PATCH v2 9/9] eeprom: at24: readability tweaks

Path csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From Bartosz Golaszewski <bgolaszewski@baylibre.com>
Newsgroups linux.kernel
Subject [RESEND PATCH v2 9/9] eeprom: at24: readability tweaks
Date Wed, 02 Dec 2015 11:30:01 +0100
Message-ID <qBcPD-5Tr-7@gated-at.bofh.it> (permalink)
References <qBcPD-5Tr-3@gated-at.bofh.it>
X-Original-To Wolfram Sang <wsa@the-dreams.de>
Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Dk9VOx6iTo256zJ57MB6HrT+TSLKzoRpe1BpkzN+gh0=; b=Lch8RE4yG3DT/NQi48Es8Z1vCj767af1WxPU3C8I27DArU3KWI1ay8c9kU7St/zYhK LpTvQJPkZaEluDyMxEpxiqNwO0a7UOaxIYX4CTuGVhIIXS6NwyP1eaNES5f3RNYDnUKM dmcwO/g43oydLDRqYw2tI+6c7H2WtB436x5gSKVeRfvjqw+oRodbiB8L3D6aaTESY0Tk LdRhbcnKSxtcknJYQag0hojZq3Ae/l54kiJkr0dH65g/yJVlwzvd36OUTfxJkHN4kGo6 BU3WAqeA4DLfQGB0MnPo3nJwu1bqme3U7F8+9XjLya7E6YJtpTqC8zcdAsAIkpRhw6jY RNVQ==
X-Google-Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Dk9VOx6iTo256zJ57MB6HrT+TSLKzoRpe1BpkzN+gh0=; b=eyEdRV8jqM9HLNSgawuFVhzVhY6UHlILFw5dBXCWJHhnkINQAh2U/P0e/tFdxmL9Sf ODHg2wbzrXDXPAtubELYuoA2BAvcwkZ5MyYZgIuXewQWjk9LXDqeTZZki90C9XBQvbgj nZW+2Lj+CsOgZgaKwafgOmB8RlS2O07MTjh0bWrZEvWWAITiXuF0JSi/OUhFLjbCEsv8 /70AeJ+vATNQFKoqSXJ1jr9vUuJjrSjsSi53b+l3ruqSs6JG/mgOg8g0vFsVbXDywZqg P/3ve2OHe5/TnU2hcau4tRV5P7hubXD9+miefwOEXDlk2SYMGJmNqZs//yguX1GLUQGH AvyQ==
X-Gm-Message-State ALoCoQmm9tRHjQWeVH/NlI5w29j09H126oZtPG0aWkumgyFd1RrI57jK7lD35e0t75q24wwXE99x
X-Received by 10.28.153.130 with SMTP id b124mr45156231wme.12.1449051943238; Wed, 02 Dec 2015 02:25:43 -0800 (PST)
X-Mailer git-send-email 2.1.4
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 50
Organization linux.* mail to news gateway
X-Original-Cc linux-i2c <linux-i2c@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org>, Bartosz Golaszewski <bgolaszewski@baylibre.com>
X-Original-Date Wed, 2 Dec 2015 11:25:26 +0100
X-Original-Message-ID <1449051926-21918-10-git-send-email-bgolaszewski@baylibre.com>
X-Original-References <1449051926-21918-1-git-send-email-bgolaszewski@baylibre.com>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1281592

Show key headers only | View raw

Move the macro definitions above the struct definitions and add some
tabs for better readability.

Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
---
 drivers/misc/eeprom/at24.c | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/drivers/misc/eeprom/at24.c b/drivers/misc/eeprom/at24.c
index 1288193..3238bf6 100644
--- a/drivers/misc/eeprom/at24.c
+++ b/drivers/misc/eeprom/at24.c
@@ -53,6 +53,14 @@
  * which won't work on pure SMBus systems.
  */
 
+#define AT24_SIZE_BYTELEN		5
+#define AT24_SIZE_FLAGS			8
+
+#define AT24_BITMASK(x)			(BIT(x) - 1)
+
+#define AT24CS_SERIAL_SIZE		16
+#define AT24CS_SERIAL_ADDR(addr)	(addr + 0x08)
+
 struct at24_data {
 	struct at24_platform_data chip;
 	struct memory_accessor macc;
@@ -99,14 +107,6 @@ static unsigned write_timeout = 25;
 module_param(write_timeout, uint, 0);
 MODULE_PARM_DESC(write_timeout, "Time (in ms) to try writes (default 25)");
 
-#define AT24_SIZE_BYTELEN 5
-#define AT24_SIZE_FLAGS 8
-
-#define AT24_BITMASK(x) (BIT(x) - 1)
-
-#define AT24CS_SERIAL_SIZE 16
-#define AT24CS_SERIAL_ADDR(addr) (addr + 0x08)
-
 /* create non-zero magic value for given eeprom parameters */
 #define AT24_DEVICE_MAGIC(_len, _flags) 		\
 	((1 << AT24_SIZE_FLAGS | (_flags)) 		\
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RESEND PATCH v2 0/9] eeprom: at24: at24cs series serial number read Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2015-12-02 11:30 +0100
  [RESEND PATCH v2 9/9] eeprom: at24: readability tweaks Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2015-12-02 11:30 +0100
  [RESEND PATCH v2 4/9] eeprom: at24: support reading of the serial number Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2015-12-02 11:30 +0100
  [RESEND PATCH v2 2/9] eeprom: at24: new flag in platform_data Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2015-12-02 11:30 +0100
  [RESEND PATCH v2 8/9] eeprom: at24: remove a reduntant if Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2015-12-02 11:30 +0100
  [RESEND PATCH v2 1/9] eeprom: at24: platform_data: use BIT() macro Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2015-12-02 11:30 +0100
  [RESEND PATCH v2 3/9] eeprom: at24: tie up an additional address for at24cs series Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2015-12-02 11:30 +0100
  [RESEND PATCH v2 5/9] eeprom: at24: export the serial number through sysfs Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2015-12-02 11:30 +0100
  [RESEND PATCH v2 6/9] eeprom: at24: improve the device_id table readability Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2015-12-02 11:30 +0100
  [RESEND PATCH v2 7/9] eeprom: at24: add the at24cs series to the list of supported devices Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2015-12-02 11:30 +0100
  Re: [RESEND PATCH v2 0/9] eeprom: at24: at24cs series serial number  read Wolfram Sang <wsa@the-dreams.de> - 2015-12-11 13:10 +0100
    Re: [RESEND PATCH v2 0/9] eeprom: at24: at24cs series serial number read Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2015-12-11 15:00 +0100

csiph-web