Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1283855
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH] mpt3sas: add PCI dependency for CONFIG_SCSI_MPT2SAS |
| Date | 2015-12-04 15:30 +0100 |
| Message-ID | <qBZx0-3Oz-7@gated-at.bofh.it> (permalink) |
| Organization | linux.* mail to news gateway |
CONFIG_SCSI_MPT2SAS was added as a backwards-compatibility helper that
selects the replacement SCSI_MPT3SAS symbol, but lacks the dependencies:
warning: (SCSI_MPT2SAS) selects SCSI_MPT3SAS which has unmet direct dependencies (SCSI_LOWLEVEL && PCI && SCSI)
0x7E5F9A79 Fri Dec 4 12:36:08 CET 2015 failed
drivers/scsi/mpt3sas/mpt3sas_base.c: In function 'mpt3sas_remove_dead_ioc_func':
drivers/scsi/mpt3sas/mpt3sas_base.c:140:2: error: implicit declaration of function 'pci_stop_and_remove_bus_device_locked' [-Werror=implicit-function-declaration]
drivers/scsi/mpt3sas/mpt3sas_base.c: In function '_base_disable_msix':
drivers/scsi/mpt3sas/mpt3sas_base.c:1921:2: error: implicit declaration of function 'pci_disable_msix' [-Werror=implicit-function-declaration]
This adds the same dependencies that SCSI_MPT3SAS has.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: b840c3627b6f ("mpt3sas: Add dummy Kconfig option for backwards compatibility")
---
This appeared on today's linux-next with ARM randconfig builds
diff --git a/drivers/scsi/mpt3sas/Kconfig b/drivers/scsi/mpt3sas/Kconfig
index 25dc38f25ec6..33dc427cfe9a 100644
--- a/drivers/scsi/mpt3sas/Kconfig
+++ b/drivers/scsi/mpt3sas/Kconfig
@@ -74,6 +74,7 @@ config SCSI_MPT3SAS_MAX_SGE
config SCSI_MPT2SAS
tristate "Legacy MPT2SAS config option"
+ depends on PCI && SCSI
default n
select SCSI_MPT3SAS
---help---
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread
[PATCH] mpt3sas: add PCI dependency for CONFIG_SCSI_MPT2SAS Arnd Bergmann <arnd@arndb.de> - 2015-12-04 15:30 +0100
Re: [PATCH] mpt3sas: add PCI dependency for CONFIG_SCSI_MPT2SAS James Bottomley <James.Bottomley@HansenPartnership.com> - 2015-12-04 17:30 +0100
Re: [PATCH] mpt3sas: add PCI dependency for CONFIG_SCSI_MPT2SAS Arnd Bergmann <arnd@arndb.de> - 2015-12-04 18:40 +0100
csiph-web