Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1283845

Re: [PATCH v4] livepatch: Cleanup module page permission changes

From Petr Mladek <pmladek@suse.com>
Newsgroups linux.kernel
Subject Re: [PATCH v4] livepatch: Cleanup module page permission changes
Date 2015-12-04 15:20 +0100
Message-ID <qBZnl-3Km-19@gated-at.bofh.it> (permalink)
References <qBKHE-2Fu-15@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Thu 2015-12-03 16:33:26, Josh Poimboeuf wrote:
> Calling set_memory_rw() and set_memory_ro() for every iteration of the
> loop in klp_write_object_relocations() is messy, inefficient, and
> error-prone.
> 
> Change all the read-only pages to read-write before the loop and convert
> them back to read-only again afterwards.
> 
> Suggested-by: Miroslav Benes <mbenes@suse.cz>
> Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>

This patch looks fine to me.

Reviewed-by: Petr Mladek <pmladek@suse.com>

Thanks,
Petr
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v4] livepatch: Cleanup module page permission changes Josh Poimboeuf <jpoimboe@redhat.com> - 2015-12-03 23:40 +0100
  Re: [PATCH v4] livepatch: Cleanup module page permission changes Jiri Kosina <jikos@kernel.org> - 2015-12-04 01:20 +0100
    Re: [PATCH v4] livepatch: Cleanup module page permission changes Rusty Russell <rusty@rustcorp.com.au> - 2015-12-04 03:00 +0100
      Re: [PATCH v4] livepatch: Cleanup module page permission changes Jiri Kosina <jikos@kernel.org> - 2015-12-04 23:00 +0100
    Re: [PATCH v4] livepatch: Cleanup module page permission changes Josh Poimboeuf <jpoimboe@redhat.com> - 2015-12-04 14:30 +0100
      Re: [PATCH v4] livepatch: Cleanup module page permission changes Josh Poimboeuf <jpoimboe@redhat.com> - 2015-12-04 14:40 +0100
      Re: [PATCH v4] livepatch: Cleanup module page permission changes Jiri Kosina <jikos@kernel.org> - 2015-12-04 23:00 +0100
        Re: [PATCH v4] livepatch: Cleanup module page permission changes Josh Poimboeuf <jpoimboe@redhat.com> - 2015-12-04 23:10 +0100
  Re: [PATCH v4] livepatch: Cleanup module page permission changes Petr Mladek <pmladek@suse.com> - 2015-12-04 15:20 +0100
  Re: [PATCH v4] livepatch: Cleanup module page permission changes Jiri Kosina <jikos@kernel.org> - 2015-12-04 23:00 +0100

csiph-web