Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1283822

Re: [PATCH v2] mm/slab.c: use list_{empty_careful,last_entry} in drain_freelist

Show all headers | View raw

On Thu, Dec 03, 2015 at 08:53:21AM -0600, Christoph Lameter wrote:
> On Thu, 3 Dec 2015, Geliang Tang wrote:
> 
> >  	while (nr_freed < tofree && !list_empty(&n->slabs_free)) {
> >
> >  		spin_lock_irq(&n->list_lock);
> > -		p = n->slabs_free.prev;
> > -		if (p == &n->slabs_free) {
> > +		if (list_empty_careful(&n->slabs_free)) {
> 
> We have taken the lock. Why do we need to be "careful"? list_empty()
> shoudl work right?

Yes. list_empty() is OK.

> 
> >  			spin_unlock_irq(&n->list_lock);
> >  			goto out;
> >  		}
> >
> > -		page = list_entry(p, struct page, lru);
> > +		page = list_last_entry(&n->slabs_free, struct page, lru);
> 
> last???

The original code delete the page from the tail of slabs_free list.

> 
> Would the the other new function that returns NULL on the empty list or
> the pointer not be useful here too and save some code?

Sorry, I don't really understand what do you mean. Can you please specify
it a little bit?

Thanks.

- Geliang

> 
> This patch seems to make it difficult to understand the code.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/3] mm/slab: use list_first_entry_or_null() Geliang Tang <geliangtang@163.com> - 2015-12-02 16:50 +0100
  [PATCH 2/3] mm/slab: use list_for_each_entry in cache_flusharray Geliang Tang <geliangtang@163.com> - 2015-12-02 16:50 +0100
    Re: [PATCH 2/3] mm/slab: use list_for_each_entry in  cache_flusharray Christoph Lameter <cl@linux.com> - 2015-12-02 17:00 +0100
  [PATCH 3/3] mm/slab: use list_{empty_careful,last_entry} in drain_freelist Geliang Tang <geliangtang@163.com> - 2015-12-02 16:50 +0100
    Re: [PATCH 3/3] mm/slab: use list_{empty_careful,last_entry} in  drain_freelist Christoph Lameter <cl@linux.com> - 2015-12-02 17:10 +0100
      [PATCH v2] mm/slab.c: use list_{empty_careful,last_entry} in drain_freelist Geliang Tang <geliangtang@163.com> - 2015-12-03 15:10 +0100
        Re: [PATCH v2] mm/slab.c: use list_{empty_careful,last_entry} in  drain_freelist Christoph Lameter <cl@linux.com> - 2015-12-03 16:00 +0100
          Re: [PATCH v2] mm/slab.c: use list_{empty_careful,last_entry} in  drain_freelist Geliang Tang <geliangtang@163.com> - 2015-12-04 14:50 +0100
            Re: [PATCH v2] mm/slab.c: use list_{empty_careful,last_entry} in  drain_freelist Christoph Lameter <cl@linux.com> - 2015-12-04 17:20 +0100
              Re: [PATCH v2] mm/slab.c: use list_{empty_careful,last_entry} in  drain_freelist Geliang Tang <geliangtang@163.com> - 2015-12-05 03:40 +0100
  Re: [PATCH 1/3] mm/slab: use list_first_entry_or_null() Christoph Lameter <cl@linux.com> - 2015-12-02 17:00 +0100

csiph-web