Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1283813

Re: [PATCH 2/7] perf test: Use machine__new_host in mma thread lookup test

Show all headers | View raw

Hi Jiri,

In the subject, please do 's/mma/mmap/'.  Ditto for 3/7.

Thanks,
Namhyung


On Thu, Dec 03, 2015 at 09:34:13AM +0100, Jiri Olsa wrote:
> This is more straightforward than what we have now.
> 
> It also fixes segfault within machine__exit, that's caused
> but not creating kernel maps for machine.. We're calling
> machine__destroy_kernel_maps in machine__exit since commit:
> 
>   ebe9729c8c31 perf machine: Fix to destroy kernel maps when machine exits
> 
> Link: http://lkml.kernel.org/n/tip-h20rqr6nyuqvcjqdmixvy9fn@git.kernel.org
> Signed-off-by: Jiri Olsa <jolsa@kernel.org>
> ---
>  tools/perf/tests/mmap-thread-lookup.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/tools/perf/tests/mmap-thread-lookup.c b/tools/perf/tests/mmap-thread-lookup.c
> index 6cdb97579c45..0c5ce44f723f 100644
> --- a/tools/perf/tests/mmap-thread-lookup.c
> +++ b/tools/perf/tests/mmap-thread-lookup.c
> @@ -149,7 +149,6 @@ static int synth_process(struct machine *machine)
>  
>  static int mmap_events(synth_cb synth)
>  {
> -	struct machines machines;
>  	struct machine *machine;
>  	int err, i;
>  
> @@ -162,8 +161,7 @@ static int mmap_events(synth_cb synth)
>  	 */
>  	TEST_ASSERT_VAL("failed to create threads", !threads_create());
>  
> -	machines__init(&machines);
> -	machine = &machines.host;
> +	machine = machine__new_host();
>  
>  	dump_trace = verbose > 1 ? 1 : 0;
>  
> @@ -203,7 +201,7 @@ static int mmap_events(synth_cb synth)
>  	}
>  
>  	machine__delete_threads(machine);
> -	machines__exit(&machines);
> +	machine__delete(machine);
>  	return err;
>  }
>  
> -- 
> 2.4.3
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/7] perf test: Fixes Jiri Olsa <jolsa@kernel.org> - 2015-12-03 09:40 +0100
  [PATCH 7/7] perf test: Create kernel maps properly for hist entries test Jiri Olsa <jolsa@kernel.org> - 2015-12-03 09:40 +0100
    Re: [PATCH 7/7] perf test: Create kernel maps properly for hist  entries test Namhyung Kim <namhyung@kernel.org> - 2015-12-04 14:30 +0100
      [PATCHv2 7/7] perf test: Create kernel maps properly for hist  entries test Jiri Olsa <jolsa@redhat.com> - 2015-12-06 17:10 +0100
  [PATCH 3/7] perf test: Use machine__new_host in mma thread code reading test Jiri Olsa <jolsa@kernel.org> - 2015-12-03 09:40 +0100
    [tip:perf/core] perf test:   Use machine__new_host in mmap thread code reading test tip-bot for Jiri Olsa <tipbot@zytor.com> - 2015-12-08 05:40 +0100
  [PATCH 2/7] perf test: Use machine__new_host in mma thread lookup test Jiri Olsa <jolsa@kernel.org> - 2015-12-03 09:40 +0100
    Re: [PATCH 2/7] perf test: Use machine__new_host in mma thread  lookup test Namhyung Kim <namhyung@kernel.org> - 2015-12-04 14:30 +0100
      Re: [PATCH 2/7] perf test: Use machine__new_host in mma thread  lookup test Jiri Olsa <jolsa@redhat.com> - 2015-12-06 17:10 +0100
    [tip:perf/core] perf test:   Use machine__new_host in mmap thread lookup test tip-bot for Jiri Olsa <tipbot@zytor.com> - 2015-12-08 05:40 +0100
  [PATCH 6/7] perf test: Use machine__new_host in thread mg sharing test Jiri Olsa <jolsa@kernel.org> - 2015-12-03 09:40 +0100
  [PATCH 1/7] perf test: Use machine__new_host in dwarf unwind test Jiri Olsa <jolsa@kernel.org> - 2015-12-03 09:40 +0100
    [tip:perf/core] perf test:   Use machine__new_host in dwarf unwind test tip-bot for Jiri Olsa <tipbot@zytor.com> - 2015-12-08 05:40 +0100
  Re: [PATCH 0/7] perf test: Fixes Jiri Olsa <jolsa@redhat.com> - 2015-12-03 10:20 +0100
  Re: [PATCH 0/7] perf test: Fixes Namhyung Kim <namhyung@kernel.org> - 2015-12-04 14:30 +0100

csiph-web