Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1283737

[tip:locking/core] sched/core: Remove false-positive warning from wake_up_process()

Show all headers | View raw

Commit-ID:  119d6f6a3be8b424b200dcee56e74484d5445f7e
Gitweb:     http://git.kernel.org/tip/119d6f6a3be8b424b200dcee56e74484d5445f7e
Author:     Sasha Levin <sasha.levin@oracle.com>
AuthorDate: Mon, 30 Nov 2015 20:34:20 -0500
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Fri, 4 Dec 2015 10:10:16 +0100

sched/core: Remove false-positive warning from wake_up_process()

Because wakeups can (fundamentally) be late, a task might not be in
the expected state. Therefore testing against a task's state is racy,
and can yield false positives.

Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Acked-by: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: oleg@redhat.com
Fixes: 9067ac85d533 ("wake_up_process() should be never used to wakeup a TASK_STOPPED/TRACED task")
Link: http://lkml.kernel.org/r/1448933660-23082-1-git-send-email-sasha.levin@oracle.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 kernel/sched/core.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index 4d568ac..fc8c987 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -2039,7 +2039,6 @@ out:
  */
 int wake_up_process(struct task_struct *p)
 {
-	WARN_ON(task_is_stopped_or_traced(p));
 	return try_to_wake_up(p, TASK_NORMAL, 0);
 }
 EXPORT_SYMBOL(wake_up_process);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] sched: remove false-positive warning from wake_up_process() Sasha Levin <sasha.levin@oracle.com> - 2015-12-01 02:40 +0100
  Re: [PATCH] sched: remove false-positive warning from wake_up_process() Linus Torvalds <torvalds@linux-foundation.org> - 2015-12-01 02:50 +0100
    Re: [PATCH] sched: remove false-positive warning from  wake_up_process() Rik van Riel <riel@redhat.com> - 2015-12-01 03:50 +0100
      Re: [PATCH] sched: remove false-positive warning from wake_up_process() Linus Torvalds <torvalds@linux-foundation.org> - 2015-12-01 04:20 +0100
  Re: [PATCH] sched: remove false-positive warning from  wake_up_process() Peter Zijlstra <peterz@infradead.org> - 2015-12-03 13:40 +0100
    Re: [PATCH] sched: remove false-positive warning from wake_up_process() Linus Torvalds <torvalds@linux-foundation.org> - 2015-12-03 19:20 +0100
  [tip:locking/core] sched/core:   Remove false-positive warning from wake_up_process() tip-bot for Sasha Levin <tipbot@zytor.com> - 2015-12-04 13:00 +0100

csiph-web