Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1283688

Re: [PATCH v6] sched/deadline: fix earliest_dl.next logic

Show all headers | View raw

On Fri, Dec 04, 2015 at 09:59:52AM +0000, Juri Lelli wrote:
> > +		if (next_node)
> > +			dl_rq->earliest_dl.next = rb_entry(next_node,
> > +				struct task_struct, pushable_dl_tasks)->dl.deadline;
> 
> Small nitpick, we are breaking 80 columns here, checkpatch should have
> complained. I guess a different indentation could help.
> 
> Apart from this, I couldn't spot any more problems with this patch.

So I don't mind the occasional violation of that rule if it aids in
better readable code.

However, that should now have included {} because the statement is
multi-line. Coding style suggests we have braces for anything over 1
line. I'll make that edit when applying, no need to resend yet another
time :-)

> Acked-by: Juri Lelli <juri.lelli@arm.com>

Thanks, I'll try and get it queued later today.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v6] sched/deadline: fix earliest_dl.next logic Wanpeng Li <kernellwp@gmail.com> - 2015-12-03 10:50 +0100
  Re: [PATCH v6] sched/deadline: fix earliest_dl.next logic Luca Abeni <luca.abeni@unitn.it> - 2015-12-03 12:20 +0100
  Re: [PATCH v6] sched/deadline: fix earliest_dl.next logic Juri Lelli <juri.lelli@arm.com> - 2015-12-04 11:00 +0100
    Re: [PATCH v6] sched/deadline: fix earliest_dl.next logic Peter Zijlstra <peterz@infradead.org> - 2015-12-04 11:20 +0100

csiph-web