Re: SoCFPGA ethernet broken

From	Pavel Machek <pavel@denx.de>
Newsgroups	linux.kernel
Subject	Re: SoCFPGA ethernet broken
Date	2015-12-04 10:40 +0100
Message-ID	<qBV0l-Sz-9@gated-at.bofh.it> (permalink)
References	(1 earlier) <qjX0B-8R-15@gated-at.bofh.it> <qjXjX-DP-5@gated-at.bofh.it> <qjXjX-DP-3@gated-at.bofh.it> <qBIZb-1y2-19@gated-at.bofh.it> <qBJBU-22d-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

> >While updating DTS might be good idea, I don't think you can simply
> >blame this on DTS. If it worked before the change, it is supposed to
> >work after the change, otherwise we call that change a "regression"
> >and revert the change.
> 
> FWIW: My initial patch to address the failure worked with the original DTB.
> 
> Also: userspace wasn't broken. So, the commandment about not breaking
> userspace wasn't broken.  Although admittedly, breaking the kernel isn't
> good either.

You can't break neither kernel nor userspace.

> >Plus, DTS is supposed to be ABI. Old DTS should still work on new
> >kernels in ideal world.
> 
> If you supply the device tree file in the kernel tree, it is not an ABI.
> 
> If the device tree is not part of the kernel, and instead comes from the
> boot firmware of the board, then you could make the ABI claim.

It is an ABI if it was declared so, and it was. Yes, it _can_ come
from kernel tree. That does not mean it has to.

									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: SoCFPGA ethernet broken Pavel Machek <pavel@denx.de> - 2015-12-03 21:50 +0100
  Re: SoCFPGA ethernet broken David Daney <ddaney@caviumnetworks.com> - 2015-12-03 22:30 +0100
    Re: SoCFPGA ethernet broken Andrew Lunn <andrew@lunn.ch> - 2015-12-04 02:20 +0100
      Re: SoCFPGA ethernet broken Andrew Lunn <andrew@lunn.ch> - 2015-12-04 03:00 +0100
        Re: SoCFPGA ethernet broken Andrew Lunn <andrew@lunn.ch> - 2015-12-04 15:40 +0100
    Re: SoCFPGA ethernet broken Pavel Machek <pavel@denx.de> - 2015-12-04 10:40 +0100

csiph-web