Re: [PATCH v4 4/9] ppc64 ftrace_with_regs configuration variables

From	Torsten Duwe <duwe@lst.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH v4 4/9] ppc64 ftrace_with_regs configuration variables
Date	2015-12-04 10:10 +0100
Message-ID	<qBUxk-Hj-13@gated-at.bofh.it> (permalink)
References	<qyM3g-RQ-3@gated-at.bofh.it> <qyM3h-RQ-19@gated-at.bofh.it> <qBEVA-7vN-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Dec 03, 2015 at 05:20:08PM +0100, Petr Mladek wrote:
>
> IMHO, we should not define CC_USING_MPROFILE_KERNEL if it is not
> supported by the compiler.

Yes, true.

> I took inspiration from the CC_USING_FENTRY handling in
> linux/Makefile. The following code worked for me:
>
> CC_USING_MPROFILE_KERNEL := $(call cc-option, -pg -mprofile-kernel -DCC_USING_MPROFILE_KERNEL)
> CC_FLAGS_FTRACE := $(CC_USING_MPROFILE_KERNEL)
> KBUILD_CPPFLAGS += $(CC_USING_MPROFILE_KERNEL)

Excellent!

> I just do not understand why we need to add the flags also
> to KBUILD_CPPFLAGS. It seems that they are duplicated
> when compiling kernel/livepatch/core.o. But livepatching
> did not work without it. I wonder if you found the culprit.

Some assembler-with-cpp files also need to be notified?

My plan is to first get this working reliably and then fine tune.

	Torsten

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v4 4/9] ppc64 ftrace_with_regs configuration variables Petr Mladek <pmladek@suse.com> - 2015-12-03 17:30 +0100
  Re: [PATCH v4 4/9] ppc64 ftrace_with_regs configuration variables Torsten Duwe <duwe@lst.de> - 2015-12-04 10:10 +0100

csiph-web