Re: [PATCH v2] dell-wmi: process Dell Instant Launch hotkey on Dell Vostro V131

Path	csiph.com!au2pb.net!2.us.feeder.erje.net!feeder.erje.net!2.eu.feeder.erje.net!newsfeed.datemas.de!weretis.net!feeder1.news.weretis.net!news.roellig-ltd.de!open-news-network.org!border2.nntp.ams1.giganews.com!border1.nntp.ams1.giganews.com!nntp.giganews.com!news.panservice.it!bofh.it!news.nic.it!robomod
From	Pali Rohár <pali.rohar@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] dell-wmi: process Dell Instant Launch hotkey on Dell Vostro V131
Date	Fri, 04 Dec 2015 10:00:03 +0100
Message-ID	<qBUnF-nU-21@gated-at.bofh.it> (permalink)
References	<qAE1A-r5-17@gated-at.bofh.it> <qAZfJ-5yU-25@gated-at.bofh.it> <qBNcv-4nR-47@gated-at.bofh.it>
X-Original-To	Darren Hart <dvhart@infradead.org>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=99fSlxS935tPvOHzjmTg6cfaSCnH3JBrM08wPuLvp00=; b=yEqs28g9Q9/3TQmg2UVILkI+M8nUYy2Aa4dPj02N46rq1Iaxo3GNBfLhAivDhXPyIo 6McG5s+3xpK0POjvGAw6n0M1n98kS9Np3IV0ziZCogQ3/xG2I/DC6/wATOyQYHjeHaG7 jscs5Vk/0YWzXp/f0/ywP6tub5oaRt2/TsM6pBTRDroMtJoe7LIJFm3IMP5PQIe2PEd7 3XAiJ6rA8KwvcKhL7HaeqnUHJ8Y3wvNuGP2PTVY5XOI/EvXqmP2V2xi6ZRXYLuUZB1j3 jzi4ESnGJh/nvp4X1hD69GgAEeEuueJsYkE9m/ruSQYNfR7WkzZh7XZEHXDlrONjlYDJ 5XDQ==
X-Received	by 10.194.87.39 with SMTP id u7mr16027820wjz.11.1449219386471; Fri, 04 Dec 2015 00:56:26 -0800 (PST)
MIME-Version	1.0
Content-Type	text/plain; charset=utf-8
Content-Disposition	inline
Content-Transfer-Encoding	8bit
User-Agent	Mutt/1.5.23.1 (2014-03-12)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	36
Organization	linux.* mail to news gateway
X-Original-Cc	Michał Kępień <kernel@kempniu.pl>, Matthew Garrett <mjg59@srcf.ucam.org>, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, Andy Lutomirski <luto@kernel.org>
X-Original-Date	Fri, 4 Dec 2015 09:56:24 +0100
X-Original-Message-ID	<20151204085624.GN10982@pali>
X-Original-References	<20151130211542.GE30553@malice.jf.intel.com> <1654e7bcde98f1cf89f698a1e359110c06c6fcd4.1448999372.git.kernel@kempniu.pl> <20151204011606.GI1800@malice.jf.intel.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1283658

Show key headers only | View raw

On Thursday 03 December 2015 17:16:06 Darren Hart wrote:
> This looks fine to me, and if Pali will ack it, I'll move it from for-review to
> testing and Andy will need to update patch 14/14 to accomodate - unless you guys
> decide to include this in his.

This patch is not enough for enabling 0xe025 key on that Vostro machine.
Some extra SMBIOS call is needed, without them ACPI will not send WMI
keypress event.

Dell SMBIOS call can be done either via WMI or via SMI inb/outb
instructions which implements dcdbas.ko driver. Module dell-laptop.ko
uses only SMBIOS API for all functionality and uses dcdbas.ko.

There is another driver which uses SMBIOS API, but use WMI calls. It is
dell-led.ko in leds subsystem.

So now I do not know where to put that needed SMBIOS call for enabling
0xe025 hotkey event and also I do not know if it is better to use WMI or
dcdbas.ko.

Maybe now it could make sense to unify Dell SMBIOS API in kernel and
move common functions to one place and let drivers to use just common
functions. According to older Dell ACPI WMI documentation in DMI is bit
which specify if BIOS support SMBIOS via WMI or not.

At least I think this one patch should not be included into kernel until
there will be full support for 0xe025 key (adding that SMBIOS call).

-- 
Pali Rohár
pali.rohar@gmail.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

Re: [PATCH] dell-wmi: add module param to control Dell Instant  Launch hotkey processing Darren Hart <dvhart@infradead.org> - 2015-11-30 22:20 +0100
  Re: [PATCH] dell-wmi: add module param to control Dell Instant  Launch hotkey processing Michał Kępień <kernel@kempniu.pl> - 2015-12-01 09:50 +0100
  [PATCH v2] dell-wmi: process Dell Instant Launch hotkey on Dell Vostro V131 Michał Kępień <kernel@kempniu.pl> - 2015-12-01 21:00 +0100
    Re: [PATCH v2] dell-wmi: process Dell Instant Launch hotkey on Dell  Vostro V131 Darren Hart <dvhart@infradead.org> - 2015-12-04 02:20 +0100
      Re: [PATCH v2] dell-wmi: process Dell Instant Launch hotkey on Dell  Vostro V131 Pali Rohár <pali.rohar@gmail.com> - 2015-12-04 10:00 +0100
        Re: [PATCH v2] dell-wmi: process Dell Instant Launch hotkey on Dell  Vostro V131 Michał Kępień <kernel@kempniu.pl> - 2015-12-04 14:30 +0100
      Re: [PATCH v2] dell-wmi: process Dell Instant Launch hotkey on Dell  Vostro V131 Michał Kępień <kernel@kempniu.pl> - 2015-12-04 14:00 +0100
        Re: [PATCH v2] dell-wmi: process Dell Instant Launch hotkey on Dell  Vostro V131 Andy Lutomirski <luto@amacapital.net> - 2015-12-04 17:10 +0100
    Re: [PATCH v2] dell-wmi: process Dell Instant Launch hotkey on Dell  Vostro V131 Pali Rohár <pali.rohar@gmail.com> - 2015-12-04 09:50 +0100
      Re: [PATCH v2] dell-wmi: process Dell Instant Launch hotkey on Dell  Vostro V131 Michał Kępień <kernel@kempniu.pl> - 2015-12-04 13:40 +0100

csiph-web