Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1283670
| From | Finn Thain <fthain@telegraphics.com.au> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [RFC PATCH 76/71] ncr5380: Enable PDMA for DTC chips |
| Date | 2015-12-04 10:30 +0100 |
| Message-ID | <qBUQG-Pe-3@gated-at.bofh.it> (permalink) |
| References | <qw6Bc-vx-5@gated-at.bofh.it> <qBLaF-34j-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Fri, 4 Dec 2015, Ondrej Zary wrote:
> @@ -685,8 +684,10 @@ static inline int NCR5380_pwrite(struct Scsi_Host *instance, unsigned char *src,
> /* All documentation says to check for this. Maybe my hardware is too
> * fast. Waiting for it seems to work fine! KLL
> */
> - while (!(i = NCR5380_read(hostdata->c400_ctl_status) & CSR_GATED_53C80_IRQ))
> + while (!(i = NCR5380_read(hostdata->c400_ctl_status) & CSR_GATED_53C80_IRQ)) {
> + udelay(4); /* DTC436 chip hangs without this */
> ; // FIXME - no timeout
> + }
>
> /*
> * I know. i is certainly != 0 here but the loop is new. See previous
>
Given that you've added braces, the redundant semicolon can be removed.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[RFC PATCH 76/71] ncr5380: Enable PDMA for DTC chips Ondrej Zary <linux@rainbow-software.org> - 2015-12-04 00:10 +0100
Re: [RFC PATCH 76/71] ncr5380: Enable PDMA for DTC chips Julian Calaby <julian.calaby@gmail.com> - 2015-12-04 01:20 +0100
Re: [RFC PATCH 76/71] ncr5380: Enable PDMA for DTC chips Finn Thain <fthain@telegraphics.com.au> - 2015-12-04 09:40 +0100
Re: [RFC PATCH 76/71] ncr5380: Enable PDMA for DTC chips Julian Calaby <julian.calaby@gmail.com> - 2015-12-05 02:40 +0100
Re: [RFC PATCH 76/71] ncr5380: Enable PDMA for DTC chips Finn Thain <fthain@telegraphics.com.au> - 2015-12-05 03:20 +0100
Re: [RFC PATCH 76/71] ncr5380: Enable PDMA for DTC chips Julian Calaby <julian.calaby@gmail.com> - 2015-12-05 03:40 +0100
Re: [RFC PATCH 76/71] ncr5380: Enable PDMA for DTC chips Finn Thain <fthain@telegraphics.com.au> - 2015-12-04 10:10 +0100
Re: [RFC PATCH 76/71] ncr5380: Enable PDMA for DTC chips Ondrej Zary <linux@rainbow-software.org> - 2015-12-04 10:40 +0100
Re: [RFC PATCH 76/71] ncr5380: Enable PDMA for DTC chips Finn Thain <fthain@telegraphics.com.au> - 2015-12-04 10:30 +0100
csiph-web