Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1283666

Re: memcg uncharge page counter mismatch

Show all headers | View raw

On Fri, Dec 04, 2015 at 09:52:27AM +0100, Michal Hocko wrote:
> On Fri 04-12-15 14:35:15, Minchan Kim wrote:
> > On Thu, Dec 03, 2015 at 04:47:29PM +0100, Michal Hocko wrote:
> > > On Thu 03-12-15 15:58:50, Michal Hocko wrote:
> > > [....]
> > > > Warning, this looks ugly as hell.
> > > 
> > > I was thinking about it some more and it seems that we should rather not
> > > bother with partial thp at all and keep it in the original memcg
> > > instead. It is way much less code and I do not think this will be too
> > > disruptive. Somebody should be holding the thp head, right?
> > > 
> > > Minchan, does this fix the issue you are seeing.
> > 
> > This patch solves the issue but not sure it's right approach.
> > I think it could make regression that in old, we could charge
> > a THP page but we can't now.
> 
> The page would still get charged when allocated. It just wouldn't get
> moved when mapped only partially. IIUC there will be still somebody
> mapping the THP head via pmd, right? That process will move the page to

If I read code correctly, No. The split_huge_pmd splits just pmd,
not page itself. IOW, it could be possible !pmd_trans_huge(pmd) &&
PageTransHuge although there is only process owns the page.

> the new memcg when moved. Or is it possible that we will end up only
> with pte mapped THP from all processes? Kirill?

I'm not Kirill but I think it's possible.
If so, a thing we can use is page_mapcount(page) == 1. With that,
it could gaurantee only a process owns the page so charge 512 instead of 1?

> 
> If not then I think it is reasonable to expect that partially mapped THP
> is not moved during task migration. I will post an official patch after
> Kirill confirms my understanding.
> 
> Anyway thanks for the testing and pointing me to right direction
> Minchan!

Thanks for the quick patch and feedback, Michal.

> 
> -- 
> Michal Hocko
> SUSE Labs

-- 
Kind regards,
Minchan Kim
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

memcg uncharge page counter mismatch Minchan Kim <minchan@kernel.org> - 2015-12-01 14:40 +0100
  Re: memcg uncharge page counter mismatch Michal Hocko <mhocko@kernel.org> - 2015-12-02 11:20 +0100
    Re: memcg uncharge page counter mismatch Minchan Kim <minchan@kernel.org> - 2015-12-03 02:40 +0100
      Re: memcg uncharge page counter mismatch Minchan Kim <minchan@kernel.org> - 2015-12-03 03:10 +0100
        Re: memcg uncharge page counter mismatch Michal Hocko <mhocko@kernel.org> - 2015-12-03 10:00 +0100
          Re: memcg uncharge page counter mismatch Minchan Kim <minchan@kernel.org> - 2015-12-03 14:00 +0100
            Re: memcg uncharge page counter mismatch Michal Hocko <mhocko@kernel.org> - 2015-12-03 14:40 +0100
              Re: memcg uncharge page counter mismatch Michal Hocko <mhocko@kernel.org> - 2015-12-03 14:50 +0100
                Re: memcg uncharge page counter mismatch Michal Hocko <mhocko@kernel.org> - 2015-12-03 16:00 +0100
                Re: memcg uncharge page counter mismatch Michal Hocko <mhocko@kernel.org> - 2015-12-03 16:50 +0100
                Re: memcg uncharge page counter mismatch Minchan Kim <minchan@kernel.org> - 2015-12-04 06:50 +0100
                Re: memcg uncharge page counter mismatch Michal Hocko <mhocko@kernel.org> - 2015-12-04 10:00 +0100
                Re: memcg uncharge page counter mismatch Minchan Kim <minchan@kernel.org> - 2015-12-04 10:20 +0100
                Re: memcg uncharge page counter mismatch Michal Hocko <mhocko@kernel.org> - 2015-12-04 11:00 +0100
                Re: memcg uncharge page counter mismatch Minchan Kim <minchan@kernel.org> - 2015-12-04 14:40 +0100
                Re: memcg uncharge page counter mismatch Johannes Weiner <hannes@cmpxchg.org> - 2015-12-04 17:10 +0100

csiph-web