[PATCH v4 1/1] atm: solos-pci: Replace simple_strtol by kstrtoint

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	LABBE Corentin <clabbe.montjoie@gmail.com>
Newsgroups	linux.kernel
Subject	[PATCH v4 1/1] atm: solos-pci: Replace simple_strtol by kstrtoint
Date	Fri, 04 Dec 2015 08:50:01 +0100
Message-ID	<qBThT-8cA-9@gated-at.bofh.it> (permalink)
References	<qBThT-8cA-5@gated-at.bofh.it>
X-Original-To	3chas3@gmail.com, linux-atm-general@lists.sourceforge.net
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=5OR+XPWrg5bIQgNZWl90AqOzrKhGkxB4RjdGecS8sKA=; b=vdYbaI9e/CSYFPSfoUIN43KIl6vi1hJ6jyjlq+RNbxmwePgnG10xq4Scv3bvc438nK CQxtKex+1UCJbXoxh+sfb3Gyf5NAIOB1o8GtHemPcrEzo9felI7ul9cuHo+BlZVrtzOZ /4z3ma0vUwL2/b0a0rFw0je/zSiULNnqFmcD18bLJ8aKkzcvw3O9kmYeoTFHLCN50INT wKot/C4OT7eHRmfgWvGkOjaAnpVw/Ty3zM/+iiFMhMaeb5PzmPsP0wPOLjQKvPsJ4kAQ k+nw0pKFqnq3/9TED1dIwGKT2Oq/5YTeppQoRUQkSBGg06xKc2Ec7x5ZJaw6W64pu3SS qq5Q==
X-Received	by 10.194.188.49 with SMTP id fx17mr17102406wjc.47.1449215012656; Thu, 03 Dec 2015 23:43:32 -0800 (PST)
X-Mailer	git-send-email 2.4.10
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	89
Organization	linux.* mail to news gateway
X-Original-Cc	LABBE Corentin <clabbe.montjoie@gmail.com>, linux-kernel@vger.kernel.org, netdev@vger.kernel.org
X-Original-Date	Fri, 4 Dec 2015 08:43:19 +0100
X-Original-Message-ID	<1449214999-6741-2-git-send-email-clabbe.montjoie@gmail.com>
X-Original-References	<1449214999-6741-1-git-send-email-clabbe.montjoie@gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1283615

Show key headers only | View raw

The simple_strtol function is obsolete.
This patch replace it by kstrtoint.
This will simplify code, since some error case not handled by
simple_strtol are handled by kstrtoint.

Signed-off-by: LABBE Corentin <clabbe.montjoie@gmail.com>
---
 drivers/atm/solos-pci.c | 28 +++++++++++++++++-----------
 1 file changed, 17 insertions(+), 11 deletions(-)

diff --git a/drivers/atm/solos-pci.c b/drivers/atm/solos-pci.c
index 3d7fb65..0c2b4ba0 100644
--- a/drivers/atm/solos-pci.c
+++ b/drivers/atm/solos-pci.c
@@ -347,8 +347,8 @@ static char *next_string(struct sk_buff *skb)
  */       
 static int process_status(struct solos_card *card, int port, struct sk_buff *skb)
 {
-	char *str, *end, *state_str, *snr, *attn;
-	int ver, rate_up, rate_down;
+	char *str, *state_str, *snr, *attn;
+	int ver, rate_up, rate_down, err;
 
 	if (!card->atmdev[port])
 		return -ENODEV;
@@ -357,7 +357,11 @@ static int process_status(struct solos_card *card, int port, struct sk_buff *skb
 	if (!str)
 		return -EIO;
 
-	ver = simple_strtol(str, NULL, 10);
+	err = kstrtoint(str, 10, &ver);
+	if (err) {
+		dev_warn(&card->dev->dev, "Unexpected status interrupt version\n");
+		return err;
+	}
 	if (ver < 1) {
 		dev_warn(&card->dev->dev, "Unexpected status interrupt version %d\n",
 			 ver);
@@ -373,16 +377,16 @@ static int process_status(struct solos_card *card, int port, struct sk_buff *skb
 		return 0;
 	}
 
-	rate_down = simple_strtol(str, &end, 10);
-	if (*end)
-		return -EIO;
+	err = kstrtoint(str, 10, &rate_down);
+	if (err)
+		return err;
 
 	str = next_string(skb);
 	if (!str)
 		return -EIO;
-	rate_up = simple_strtol(str, &end, 10);
-	if (*end)
-		return -EIO;
+	err = kstrtoint(str, 10, &rate_up);
+	if (err)
+		return err;
 
 	state_str = next_string(skb);
 	if (!state_str)
@@ -417,7 +421,7 @@ static int process_command(struct solos_card *card, int port, struct sk_buff *sk
 	struct solos_param *prm;
 	unsigned long flags;
 	int cmdpid;
-	int found = 0;
+	int found = 0, err;
 
 	if (skb->len < 7)
 		return 0;
@@ -428,7 +432,9 @@ static int process_command(struct solos_card *card, int port, struct sk_buff *sk
 	    skb->data[6] != '\n')
 		return 0;
 
-	cmdpid = simple_strtol(&skb->data[1], NULL, 10);
+	err = kstrtoint(&skb->data[1], 10, &cmdpid);
+	if (err)
+		return err;
 
 	spin_lock_irqsave(&card->param_queue_lock, flags);
 	list_for_each_entry(prm, &card->param_queue, list) {
-- 
2.4.10

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH v4 0/1] atm: solos-pci: Replace simple_strtol by kstrtoint LABBE Corentin <clabbe.montjoie@gmail.com> - 2015-12-04 08:50 +0100
  [PATCH v4 1/1] atm: solos-pci: Replace simple_strtol by kstrtoint LABBE Corentin <clabbe.montjoie@gmail.com> - 2015-12-04 08:50 +0100
    Re: [PATCH v4 1/1] atm: solos-pci: Replace simple_strtol by  kstrtoint David Miller <davem@davemloft.net> - 2015-12-06 00:00 +0100

csiph-web