Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1283612

[PATCH] usb: gadget: make usb_ep_enable return -EBUSY if ep has already enabled

From changbin.du@intel.com
Newsgroups linux.kernel
Subject [PATCH] usb: gadget: make usb_ep_enable return -EBUSY if ep has already enabled
Date 2015-12-04 08:40 +0100
Message-ID <qBT8d-89d-7@gated-at.bofh.it> (permalink)
Organization linux.* mail to news gateway

Show all headers | View raw


From: "Du, Changbin" <changbin.du@intel.com>

When usb_ep_enable on a enabled ep, the configuration of the ep probably
has changed. In this scenario, the ep configuration in hw should be
reprogrammed by udc driver. Hence, it is better to return an error to
inform the caller.

Signed-off-by: Du, Changbin <changbin.du@intel.com>
---
 include/linux/usb/gadget.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/usb/gadget.h b/include/linux/usb/gadget.h
index d813bd2..89f9fdd 100644
--- a/include/linux/usb/gadget.h
+++ b/include/linux/usb/gadget.h
@@ -268,7 +268,7 @@ static inline int usb_ep_enable(struct usb_ep *ep)
 	int ret;
 
 	if (ep->enabled)
-		return 0;
+		return -EBUSY;
 
 	ret = ep->ops->enable(ep, ep->desc);
 	if (ret)
-- 
2.5.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextNext in thread | Find similar | Unroll thread


Thread

[PATCH] usb: gadget: make usb_ep_enable return -EBUSY if ep has already enabled changbin.du@intel.com - 2015-12-04 08:40 +0100
  Re: [PATCH] usb: gadget: make usb_ep_enable return -EBUSY if ep has already enabled Felipe Balbi <balbi@ti.com> - 2015-12-10 18:30 +0100

csiph-web