Re: [PATCH] nvdimm: improve diagnosibility of namespaces

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!border1.nntp.ams1.giganews.com!nntp.giganews.com!news.panservice.it!bofh.it!news.nic.it!robomod
From	Dan Williams <dan.j.williams@intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] nvdimm: improve diagnosibility of namespaces
Date	Fri, 04 Dec 2015 04:00:02 +0100
Message-ID	<qBOLg-5es-7@gated-at.bofh.it> (permalink)
References	<qB0Y9-6H7-7@gated-at.bofh.it>
X-Original-To	"Dmitry V. Krivenok" <krivenok.dmitry@gmail.com>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=3BAt6mDjurOKU2UmkUTVIPK97qsbiUnPEq1M6fJ04Zo=; b=iYYuWPAdp/qVn+pnAa6cqrTNm/SGv1dmJXOJSZjN2EgBBbnXO+69RlbTexfpOA3KmG FCeHp9fWMYmTAWWUZUdYWSI8SEVtFEziOYI327XLU7NlRi4D6QIVKsnnAQJuDWKsCUmX AgMe4uOg7wOfiVglIIoaRaU1v6ZzQUaz9lks8xJbeqzMwEOzWNOuQ9gvC+rtvSbWslvS EEI59eOKyKebfzuFoe/FFoLWFuiy9rH90LdTZzwHgo5RwEYCwaILzznUBLjvqKBP153/ 6ta5eyZVWUCg0xeJKn3+45ErrMwLK4oGO/HNdsVZ13Tv+9CAYhijT8G9aK644nWQSd/G Hj/A==
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=3BAt6mDjurOKU2UmkUTVIPK97qsbiUnPEq1M6fJ04Zo=; b=fWuEa1aGMa5EQnEusaDHN+K8EEjU7cUJLq4a+YV7UwJek0AYCNg+kE0j7dcHWxnMBx 18/yjYbuXuIvqFHnyKd0br3Y98qF30q4DHHt8KZRPN5yqc/9hNPuhmHuarUl/F7QcwJX NZrhPxwF8FKEkFf/FLifIKKimSv2NNoMZt1sOZQnFuXXzmgGZetVOqHxJ/Mhnzud6Aah rBpNcchLwsX6AHa3foCaWY6PWEiqVX1P2JCxNfneQ0N/3jZSyyL6qv0dVWa0IEoo2hgS o62TbIrajlERN/+Qjeq2kE3KBXifWOezdsflTqlg2HRJ102237XOqH4u7Aj47F5kE77l rMaQ==
X-Gm-Message-State	ALoCoQljtS3+nwjF5ww+SEo4zYh1mHZDqAT1p8UGCpjR/qlwkAPGo+FbT1hgZPpHZB6nlJiXHiac
MIME-Version	1.0
X-Received	by 10.129.51.82 with SMTP id z79mr9119444ywz.198.1449197553046; Thu, 03 Dec 2015 18:52:33 -0800 (PST)
Content-Type	text/plain; charset=UTF-8
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	38
Organization	linux.* mail to news gateway
X-Original-Cc	"linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
X-Original-Date	Thu, 3 Dec 2015 18:52:32 -0800
X-Original-Message-ID	<CAPcyv4ghneEfKyOp35x2WurE52aWEfS-fGPg56oeOq407tTe6Q@mail.gmail.com>
X-Original-References	<1449006492-1474-1-git-send-email-krivenok.dmitry@gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1283564

Show key headers only | View raw

On Tue, Dec 1, 2015 at 1:48 PM, Dmitry V. Krivenok
<krivenok.dmitry@gmail.com> wrote:
> In order to bind namespace to the driver user must first
> set all mandatory attributes in the following order:
> - uuid
> - size
> - sector_size (for blk namespace only)
>
> If the order is wrong, then user either won't be able to set
> the attribute or bind the namespace.
>
> This simple patch improves diagnosibility of common operations
> with namespaces by printing some details about the error
> instead of failing silently.
>
> Below are examples of error messages (assuming dyndbg is
> enabled for nvdimms):
>
> [/]# echo 4194304 > /sys/bus/nd/devices/region5/namespace5.0/size
> [  288.372612] nd namespace5.0: __size_store: uuid not set
> [  288.374839] nd namespace5.0: size_store: 400000 fail (-6)
> sh: write error: No such device or address
> [/]#
>
> [/]# echo namespace5.0 > /sys/bus/nd/drivers/nd_blk/bind
> [  554.671648] nd_blk namespace5.0: nvdimm_namespace_common_probe: sector size not set
> [  554.674688]  ndbus1: nd_blk.probe(namespace5.0) = -19
> sh: write error: No such device
> [/]#
>
> Signed-off-by: Dmitry V. Krivenok <krivenok.dmitry@gmail.com>

Looks good I'll queue it for 4.5.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] nvdimm: improve diagnosibility of namespaces "Dmitry V. Krivenok" <krivenok.dmitry@gmail.com> - 2015-12-01 22:50 +0100
  Re: [PATCH] nvdimm: improve diagnosibility of namespaces Dan Williams <dan.j.williams@intel.com> - 2015-12-04 04:00 +0100

csiph-web