Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1283450

[PATCH, RESEND] staging: iio: select IRQ_WORK for IIO_DUMMY_EVGEN

Show all headers | View raw

The iio dummy code was recently changed to use irq_work_queue, but
that code is compiled into the kernel only if IRQ_WORK is set, so
we can get a link error here:

drivers/built-in.o: In function `iio_evgen_poke':
(.text+0x208a04): undefined reference to `irq_work_queue'

This changes the Kconfig file to match what other drivers do.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: fd2bb310ca3d ("Staging: iio: Move evgen interrupt generation to irq_work")
Acked-by: Daniel Baluta <daniel.baluta@intel.com>
---
I submitted the patch before and it was accepted, but then it
apparently got lost when the driver was moved out of staging,
and the bug came back with today's linux-next


diff --git a/drivers/iio/dummy/Kconfig b/drivers/iio/dummy/Kconfig
index e8676aa97d62..71805ced1aae 100644
--- a/drivers/iio/dummy/Kconfig
+++ b/drivers/iio/dummy/Kconfig
@@ -5,7 +5,8 @@ menu "IIO dummy driver"
 	depends on IIO
 
 config IIO_DUMMY_EVGEN
-       tristate
+	select IRQ_WORK
+	tristate
 
 config IIO_SIMPLE_DUMMY
        tristate "An example driver with no hardware requirements"

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH, RESEND] staging: iio: select IRQ_WORK for IIO_DUMMY_EVGEN Arnd Bergmann <arnd@arndb.de> - 2015-12-04 00:30 +0100
  Re: [PATCH, RESEND] staging: iio: select IRQ_WORK for IIO_DUMMY_EVGEN Jonathan Cameron <jic23@kernel.org> - 2015-12-05 18:40 +0100

csiph-web