Re: [PATCH] stmmac: ipq806x: Return error values instead of pointers

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH] stmmac: ipq806x: Return error values instead of pointers
Date	2015-12-03 21:30 +0100
Message-ID	<qBIFP-1rh-3@gated-at.bofh.it> (permalink)
References	<qBwY2-21w-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Stephen Boyd <sboyd@codeaurora.org>
Date: Wed,  2 Dec 2015 23:55:15 -0800

> Typically we return error pointers when we want to use those
> pointers in the non-error case, but this function is just
> returning error pointers or NULL for success. Change the style to
> plain int to follow normal kernel coding styles.
> 
> Cc: Joachim Eastwood <manabian@gmail.com>
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] stmmac: ipq806x: Return error values instead of pointers Stephen Boyd <sboyd@codeaurora.org> - 2015-12-03 09:00 +0100
  Re: [PATCH] stmmac: ipq806x: Return error values instead of  pointers David Miller <davem@davemloft.net> - 2015-12-03 21:30 +0100

csiph-web