Re: [PATCH v4 8/9] Implement kernel live patching for ppc64le (ABIv2)

Path	csiph.com!goblin1!goblin2!goblin.stu.neva.ru!gothmog.csi.it!bofh.it!news.nic.it!robomod
From	Petr Mladek <pmladek@suse.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v4 8/9] Implement kernel live patching for ppc64le (ABIv2)
Date	Thu, 03 Dec 2015 17:30:03 +0100
Message-ID	<qBEVB-7vN-31@gated-at.bofh.it> (permalink)
References	<qyM3g-RQ-3@gated-at.bofh.it> <qyM3h-RQ-29@gated-at.bofh.it>
X-Original-To	Torsten Duwe <duwe@lst.de>
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.21 (2010-09-15)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	42
Organization	linux.* mail to news gateway
X-Original-Cc	Steven Rostedt <rostedt@goodmis.org>, Michael Ellerman <mpe@ellerman.id.au>, Jiri Kosina <jkosina@suse.cz>, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, live-patching@vger.kernel.org
X-Original-Date	Thu, 3 Dec 2015 17:24:45 +0100
X-Original-Message-ID	<20151203162445.GG8047@pathway.suse.cz>
X-Original-References	<20151125172608.9588569260@newverein.lst.de> <20151125172937.9425E69260@newverein.lst.de>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1283174

Show key headers only | View raw

On Wed 2015-11-25 17:48:36, Torsten Duwe wrote:
>   * create the appropriate files+functions
>     arch/powerpc/include/asm/livepatch.h
>         klp_check_compiler_support,
>         klp_arch_set_pc
>     arch/powerpc/kernel/livepatch.c with a stub for
>         klp_write_module_reloc
>     This is architecture-independent work in progress.
>   * introduce a fixup in arch/powerpc/kernel/entry_64.S
>     for local calls that are becoming global due to live patching.
>     And of course do the main KLP thing: return to a maybe different
>     address, possibly altered by the live patching ftrace op.
> 
> --- /dev/null
> +++ b/arch/powerpc/include/asm/livepatch.h
> @@ -0,0 +1,45 @@
[...]
> +#include <linux/module.h>
> +#include <linux/ftrace.h>
> +
> +#ifdef CONFIG_LIVEPATCH
> +static inline int klp_check_compiler_support(void)
> +{
> +#if !defined(_CALL_ELF) || _CALL_ELF != 2

I am just curious why we do not check CC_USING_MPROFILE_KERNEL
like in the other similar locations. It would look less cryptic.
But I am not sure if it is precise enough.

Best Regards,
Petr

> +	return 1;
> +#endif
> +	return 0;
> +}
> +
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v4 8/9] Implement kernel live patching for ppc64le (ABIv2) Petr Mladek <pmladek@suse.com> - 2015-12-03 17:30 +0100
  Re: [PATCH v4 8/9] Implement kernel live patching for ppc64le  (ABIv2) Torsten Duwe <duwe@lst.de> - 2015-12-04 10:10 +0100

csiph-web