4.0 -> 4.1 regression : after resume from s2ram both internal and external display of a docked ThinkPad ate black

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Pavel Machek <pavel@ucw.cz>
Newsgroups	linux.kernel
Subject	4.0 -> 4.1 regression : after resume from s2ram both internal and external display of a docked ThinkPad ate black
Date	Thu, 03 Dec 2015 17:10:02 +0100
Message-ID	<qBECe-7oz-9@gated-at.bofh.it> (permalink)
References	<pRA3M-1sA-13@gated-at.bofh.it> <pSWbT-5Oa-7@gated-at.bofh.it> <pTJFE-2bp-17@gated-at.bofh.it> <qfUul-5M0-13@gated-at.bofh.it> <qp3f4-5BD-13@gated-at.bofh.it> <qpeka-45t-35@gated-at.bofh.it>
X-Original-To	Toralf Förster <toralf.foerster@gmx.de>
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.23 (2014-03-12)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	63
Organization	linux.* mail to news gateway
X-Original-Cc	Dave Airlie <airlied@redhat.com>, intel-gfx <intel-gfx@lists.freedesktop.org>, Linux Kernel <linux-kernel@vger.kernel.org>, daniel.vetter@intel.com, jani.nikula@linux.intel.com
X-Original-Date	Thu, 3 Dec 2015 17:06:59 +0100
X-Original-Message-ID	<20151203160659.GB31751@amd>
X-Original-References	<55B8DAF8.6070805@gmx.de> <20150802074334.GG3720@amd> <55C0B038.8090807@gmx.de> <56115416.7040404@gmx.de> <20151029214933.GA18861@amd> <56333A8A.3000707@gmx.de>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1283157

Show key headers only | View raw

> >>> commit e7d6f7d708290da1b7c92f533444b042c79412e0
> >>> Author: Dave Airlie <airlied@redhat.com>
> >>> Date:   Mon Dec 8 13:23:37 2014 +1000
> >>>
> >>>     drm/i915: resume MST after reading back hw state
....
> >> Is there anything else what I can do ?
> >>
> >> Current kernels up to 4.2.3 and 4.3-rc3 (not hardened) shows this issue here at my system.
> > 
> > Yes. Now you ask Dave Airlie <airlied@redhat.com> to fix it. If that
> 
> Dear Dave,
> 
> please fix it.
> 
> Here's a work around which works for me since kernel 4.1.x :

Dave. You broke it. You fix it. Don't make me less polite?

Daniel? Jani? Can you apply the patch below, or comment whats wrong
with that?

This is a regression, so it should not require much thinking.

									Pavel

> diff --git a/drivers/gpu/drm/i915/i915_drv.c
> b/drivers/gpu/drm/i915/i915_drv.c
> index ab64d68..3aeead2 100644
> --- a/drivers/gpu/drm/i915/i915_drv.c
> +++ b/drivers/gpu/drm/i915/i915_drv.c
> @@ -740,6 +740,8 @@ static int i915_drm_resume(struct drm_device *dev)
>         if (dev_priv->display.hpd_irq_setup)
>                 dev_priv->display.hpd_irq_setup(dev);
>         spin_unlock_irq(&dev_priv->irq_lock);
> +
> +       intel_dp_mst_resume(dev);
> 
>         drm_modeset_lock_all(dev);
>         intel_display_resume(dev);
> 
> 
> > does not work, you ask him to fix it, in less polite words. If that
> > does not work, you verify that reverting
> > e7d6f7d708290da1b7c92f533444b042c79412e0 fixes it for you, then ask
> > Daniel Vetter and Jani Nikula to revert it. If they fail to do that,
> > you go all the way up to Linus.
> > 
> > Good luck ;-), 
> > 									Pavel
> > 
> 
> 

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

4.0 -> 4.1 regression : after resume from s2ram both internal and  external display of a docked ThinkPad ate black Pavel Machek <pavel@ucw.cz> - 2015-12-03 17:10 +0100

csiph-web