Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1283090

Re: [rtc-linux] [PATCH] RTC: RK808: Work around hardware bug on November 31st

From Alexandre Belloni <alexandre.belloni@free-electrons.com>
Newsgroups linux.kernel
Subject Re: [rtc-linux] [PATCH] RTC: RK808: Work around hardware bug on November 31st
Date 2015-12-03 15:50 +0100
Message-ID <qBDmN-6pd-3@gated-at.bofh.it> (permalink)
References <qBrlE-6L5-9@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

Hi,

I would have liked to be in copy of that mail. Maybe you used
get_maintainers on an old tree?

On 02/12/2015 at 17:53:04 -0800, Julius Werner wrote :
> In Fuzhou, China, the month of November seems to be having 31 days.
> That's nice and all (I'm sure you can get a lot more done in a year that
> way), but back here in other parts of the world we are not so lucky.
> Therefore, if we read that date from the RTC we should correct it to
> December 1st.
> 

Wow, nice one...

I hope reading the time properly fails thanks to the rtc_valid_tm(tm) in
__rtc_read_time().

> This is not a full workaround. Since the RTC actually ticks all the way
> through that imaginary day, there's no easy way to detect and correct
> this issue if the device was offline the whole time and allowed it to
> tick through to December 1st on the Rockchip calendar (which would be
> December 2nd on the Gregorian one). Those edge cases can only really be
> solved by regularly syncing to an external time source (e.g. NTP).
> 

It will also happen if nobody reads the RTC time for that day (highly
improbable in a default configuration). Do you need that patch for 4.4
or can it wait 4.5?


> Signed-off-by: Julius Werner <jwerner@chromium.org>
> Reviewed-by: Chris Zhong <zyw@rock-chips.com>
> ---
>  drivers/rtc/rtc-rk808.c | 93 ++++++++++++++++++++++++++-----------------------
>  1 file changed, 50 insertions(+), 43 deletions(-)
> 

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] RTC: RK808: Work around hardware bug on November 31st Julius Werner <jwerner@chromium.org> - 2015-12-03 03:00 +0100
  Re: [rtc-linux] [PATCH] RTC: RK808: Work around hardware bug on  November 31st Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2015-12-03 15:50 +0100
    Re: [rtc-linux] [PATCH] RTC: RK808: Work around hardware bug on  November 31st Julius Werner <jwerner@chromium.org> - 2015-12-03 18:00 +0100
  Re: [PATCH] RTC: RK808: Work around hardware bug on November 31st Doug Anderson <dianders@chromium.org> - 2015-12-05 01:00 +0100
    Re: [PATCH] RTC: RK808: Work around hardware bug on November 31st Julius Werner <jwerner@chromium.org> - 2015-12-05 01:30 +0100
      Re: [PATCH] RTC: RK808: Work around hardware bug on November 31st Doug Anderson <dianders@chromium.org> - 2015-12-05 02:00 +0100
        Re: [PATCH] RTC: RK808: Work around hardware bug on November 31st Julius Werner <jwerner@chromium.org> - 2015-12-05 03:00 +0100
          Re: [PATCH] RTC: RK808: Work around hardware bug on November 31st Doug Anderson <dianders@chromium.org> - 2015-12-05 05:10 +0100
            Re: [PATCH] RTC: RK808: Work around hardware bug on November 31st Doug Anderson <dianders@chromium.org> - 2015-12-05 06:00 +0100
              Re: [PATCH] RTC: RK808: Work around hardware bug on November 31st Julius Werner <jwerner@chromium.org> - 2015-12-05 08:20 +0100
                Re: [PATCH] RTC: RK808: Work around hardware bug on November 31st Doug Anderson <dianders@chromium.org> - 2015-12-06 01:40 +0100
                Re: [PATCH] RTC: RK808: Work around hardware bug on November 31st Chris Zhong <zyw@rock-chips.com> - 2015-12-07 02:40 +0100
                Re: [PATCH] RTC: RK808: Work around hardware bug on November 31st Doug Anderson <dianders@chromium.org> - 2015-12-07 04:00 +0100
                Re: [PATCH] RTC: RK808: Work around hardware bug on November 31st Doug Anderson <dianders@chromium.org> - 2015-12-07 04:00 +0100
                Re: [PATCH] RTC: RK808: Work around hardware bug on November 31st Chris Zhong <zyw@rock-chips.com> - 2015-12-07 04:10 +0100
                Re: [PATCH] RTC: RK808: Work around hardware bug on November 31st Julius Werner <jwerner@chromium.org> - 2015-12-07 21:30 +0100
                Re: [PATCH] RTC: RK808: Work around hardware bug on November 31st Julius Werner <jwerner@chromium.org> - 2015-12-07 23:50 +0100
                Re: [PATCH] RTC: RK808: Work around hardware bug on November 31st Doug Anderson <dianders@chromium.org> - 2015-12-08 02:20 +0100
                Re: [PATCH] RTC: RK808: Work around hardware bug on November 31st Julius Werner <jwerner@chromium.org> - 2015-12-08 02:50 +0100
                Re: [PATCH] RTC: RK808: Work around hardware bug on November 31st Julius Werner <jwerner@chromium.org> - 2015-12-08 06:30 +0100
                [PATCH v2] RTC: RK808: Work around hardware bug on November 31st Julius Werner <jwerner@chromium.org> - 2015-12-08 06:30 +0100
                Re: [PATCH v2] RTC: RK808: Work around hardware bug on November 31st Doug Anderson <dianders@chromium.org> - 2015-12-09 06:50 +0100
                Re: [PATCH v2] RTC: RK808: Work around hardware bug on November 31st Julius Werner <jwerner@chromium.org> - 2015-12-09 22:40 +0100
                Re: [PATCH v2] RTC: RK808: Work around hardware bug on November 31st Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2015-12-10 19:50 +0100
                Re: [PATCH v2] RTC: RK808: Work around hardware bug on November 31st Julius Werner <jwerner@chromium.org> - 2015-12-10 20:00 +0100

csiph-web