Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1283010

[PATCH 11/17] ARC: dw2 unwind: Elide REG_INVALID check

Show all headers | View raw

REG_INVALID checks if reg_info[*].width is zero, which is compile time
contant set to NON zero. No point in checking it.

Signed-off-by: Vineet Gupta <vgupta@synopsys.com>
---
 arch/arc/kernel/unwind.c | 20 ++------------------
 1 file changed, 2 insertions(+), 18 deletions(-)

diff --git a/arch/arc/kernel/unwind.c b/arch/arc/kernel/unwind.c
index f2a486d9dac2..b1a520afcbcb 100644
--- a/arch/arc/kernel/unwind.c
+++ b/arch/arc/kernel/unwind.c
@@ -48,10 +48,6 @@ static const struct {
 	unsigned width:BITS_PER_LONG / 2;
 } reg_info[] = { UNW_REGISTER_INFO };
 
-#ifndef REG_INVALID
-#define REG_INVALID(r) (reg_info[r].width == 0)
-#endif
-
 #define DW_CFA_nop                          0x00
 #define DW_CFA_set_loc                      0x01
 #define DW_CFA_advance_loc1                 0x02
@@ -868,9 +864,7 @@ static int cie_validate(const u32 *cie, struct cie *t_cie)
 	t_cie->fde_pointer_type = ptrType;
 
 	if (ptr > end
-	    || retAddrReg >= ARRAY_SIZE(reg_info)
-	    || REG_INVALID(retAddrReg)
-	    || reg_info[retAddrReg].width != sizeof(unsigned long))
+	    || retAddrReg >= ARRAY_SIZE(reg_info))
 		return 0;
 
 	unw_debug("\nDwarf Unwinder setup: CIE Info:\n");
@@ -1017,19 +1011,11 @@ int arc_unwind(struct unwind_frame_info *frame)
 		  state.cfa.reg, state.cfa.offs, cfa);
 
 	for (i = 0; i < ARRAY_SIZE(state.regs); ++i) {
-		if (REG_INVALID(i)) {
-			if (state.regs[i].where == Nowhere)
-				continue;
-			return -EIO;
-		}
 		switch (state.regs[i].where) {
 		default:
 			break;
 		case Register:
-			if (state.regs[i].value >= ARRAY_SIZE(reg_info)
-			    || REG_INVALID(state.regs[i].value)
-			    || reg_info[i].width >
-			    reg_info[state.regs[i].value].width)
+			if (state.regs[i].value >= ARRAY_SIZE(reg_info))
 				return -EIO;
 			switch (reg_info[state.regs[i].value].width) {
 			case sizeof(u8):
@@ -1061,8 +1047,6 @@ int arc_unwind(struct unwind_frame_info *frame)
 	fptr = (unsigned long *)(&frame->regs);
 	for (i = 0; i < ARRAY_SIZE(state.regs); ++i, fptr++) {
 
-		if (REG_INVALID(i))
-			continue;
 		switch (state.regs[i].where) {
 		case Nowhere:
 			if (reg_info[i].width != sizeof(UNW_SP(frame))
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RFC 00/17] ARC Dwarf unwinder improvements Vineet Gupta <Vineet.Gupta1@synopsys.com> - 2015-12-03 13:50 +0100
  [PATCH 11/17] ARC: dw2 unwind: Elide REG_INVALID check Vineet Gupta <Vineet.Gupta1@synopsys.com> - 2015-12-03 13:50 +0100
  [PATCH 13/17] ARC: dw2 unwind: Assume all regs to be unsigned long Vineet Gupta <Vineet.Gupta1@synopsys.com> - 2015-12-03 13:50 +0100
  [PATCH 06/17] ARC: dw2 unwind: Don't verify Main FDE Table size everytime Vineet Gupta <Vineet.Gupta1@synopsys.com> - 2015-12-03 13:50 +0100
  [PATCH 05/17] ARC: dw2 unwind: Better printing Vineet Gupta <Vineet.Gupta1@synopsys.com> - 2015-12-03 13:50 +0100
  [PATCH 01/17] ARC: dw2 unwind: Elide generation of const propagated clones Vineet Gupta <Vineet.Gupta1@synopsys.com> - 2015-12-03 13:50 +0100
  [PATCH 03/17] ARC: dw2 unwind: Remove handling of for signal frame Vineet Gupta <Vineet.Gupta1@synopsys.com> - 2015-12-03 13:50 +0100
  [PATCH 10/17] ARC: dw2 unwind: CIE parsing/validation done only once at startup Vineet Gupta <Vineet.Gupta1@synopsys.com> - 2015-12-03 13:50 +0100
  [PATCH 08/17] ARC: dw2 unwind: Don't verify FDE lookup table metadata Vineet Gupta <Vineet.Gupta1@synopsys.com> - 2015-12-03 13:50 +0100

csiph-web