Re: [PATCH v3 1/1] atm: solos-pci: Replace simple_strtol by kstrtoint

From	LABBE Corentin <clabbe.montjoie@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 1/1] atm: solos-pci: Replace simple_strtol by kstrtoint
Date	2015-12-03 14:00 +0100
Message-ID	<qBBEl-58q-3@gated-at.bofh.it> (permalink)
References	<qBx7I-2kH-1@gated-at.bofh.it> <qBx7I-2kH-9@gated-at.bofh.it> <qBAff-4hh-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Dec 03, 2015 at 06:26:31AM -0500, Charles (Chas) Williams wrote:
> On Thu, 2015-12-03 at 09:06 +0100, LABBE Corentin wrote:
> > @@ -357,11 +357,11 @@ static int process_status(struct solos_card *card, int port, struct sk_buff *skb
> >  	if (!str)
> >  		return -EIO;
> >  
> > -	ver = simple_strtol(str, NULL, 10);
> > -	if (ver < 1) {
> > +	err = kstrtoint(str, 10, &ver);
> > +	if (err || ver < 1) {
> >  		dev_warn(&card->dev->dev, "Unexpected status interrupt version %d\n",
> >  			 ver);
> > -		return -EIO;
> > +		return err;
> 
> 
> If ver < 1 then you might return a 0 here.  Always returning -EIO is
> probably just fine.
> 

Hello

I think the best solution is to split the test, since returning error code from kstrtoint was asked by David Miller.
if (err)
	return err;
if (ver < 1)
	return -EIO;
Thanks
Regards
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH v3 0/1] atm: solos-pci: Replace simple_strtol by kstrtoint LABBE Corentin <clabbe.montjoie@gmail.com> - 2015-12-03 09:10 +0100
  [PATCH v3 1/1] atm: solos-pci: Replace simple_strtol by kstrtoint LABBE Corentin <clabbe.montjoie@gmail.com> - 2015-12-03 09:10 +0100
    Re: [PATCH v3 1/1] atm: solos-pci: Replace simple_strtol by  kstrtoint "Charles (Chas) Williams" <3chas3@gmail.com> - 2015-12-03 12:30 +0100
      Re: [PATCH v3 1/1] atm: solos-pci: Replace simple_strtol by kstrtoint LABBE Corentin <clabbe.montjoie@gmail.com> - 2015-12-03 14:00 +0100
        Re: [PATCH v3 1/1] atm: solos-pci: Replace simple_strtol by  kstrtoint "Charles (Chas) Williams" <3chas3@gmail.com> - 2015-12-03 17:40 +0100

csiph-web