Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1281494

RE: [v8, 2/6] fsl/fman: Add FMan support

Show all headers | View raw

Hi David,
Thank you for your feedback, I'll address it and re-submit.

Regards,
Igal Liberman

> -----Original Message-----
> From: David Miller [mailto:davem@davemloft.net]
> Sent: Tuesday, December 01, 2015 11:28 PM
> To: Liberman Igal-B31950 <Igal.Liberman@freescale.com>
> Cc: netdev@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; linux-
> kernel@vger.kernel.org; Wood Scott-B07421 <scottwood@freescale.com>;
> Bucur Madalin-Cristian-B32716 <madalin.bucur@freescale.com>;
> pebolle@tiscali.nl; joakim.tjernlund@transmode.se; ppc@mindchasers.com;
> stephen@networkplumber.org
> Subject: Re: [v8, 2/6] fsl/fman: Add FMan support
> 
> From: <igal.liberman@freescale.com>
> Date: Mon, 30 Nov 2015 14:20:58 +0200
> 
> > +typedef irqreturn_t (fman_exceptions_cb)(struct fman *fman,
> > +					 enum fman_exceptions exception);
> 
> Function and function pointer declarations and definitions should be
> indented such that the second and subsequent lines begin precisely at the
> first column after the openning parenthesis of the first line.
> 
> Please audit this and fix it in your entire submission, almost ever new such
> case is done incorrectly.
> 
> > +	fman->state->exceptions = (EX_DMA_BUS_ERROR                 |
> > +					EX_DMA_READ_ECC              |
> > +					EX_DMA_SYSTEM_WRITE_ECC      |
> > +					EX_DMA_FM_WRITE_ECC          |
> > +					EX_FPM_STALL_ON_TASKS        |
> > +					EX_FPM_SINGLE_ECC            |
> > +					EX_FPM_DOUBLE_ECC            |
> > +
> 	EX_QMI_DEQ_FROM_UNKNOWN_PORTID |
> > +					EX_BMI_LIST_RAM_ECC          |
> > +					EX_BMI_STORAGE_PROFILE_ECC   |
> > +					EX_BMI_STATISTICS_RAM_ECC    |
> > +					EX_MURAM_ECC                 |
> > +					EX_BMI_DISPATCH_RAM_ECC      |
> > +					EX_QMI_DOUBLE_ECC            |
> > +					EX_QMI_SINGLE_ECC);
> 
> The same applies to multi-line parenthesized expressions like this one.
> Again, please audit and fix this in your entire submission.
> 
> Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [v8, 2/6] fsl/fman: Add FMan support David Miller <davem@davemloft.net> - 2015-12-01 22:30 +0100
  RE: [v8, 2/6] fsl/fman: Add FMan support Liberman Igal <Igal.Liberman@freescale.com> - 2015-12-02 08:10 +0100

csiph-web