Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1281458

Re: [PATCH 3/6] net: thunderx: Increase transmit queue length

Show all headers | View raw

>The driver should successfully recover from out of memory situations
> and not stop RX/TX completely.
This memory allocation is while interface bringup/initialization and not during
packet I/O.

>Don't put this off as not "related" to your patch, it is as this
>introduces the behavior for this user, and you should fix it before
>expecting me to apply this patch series.
I would disagree on this, as this patch hasn't introduced any failure here,
if this user has connected any device which asks for a bit large amount
of coherent memory then i am sure he will see the same issue.
And above i have suggested what could be done to not see this issue.

But anyway for the time being I will resubmit the patch series without this
patch, hope that would be okay.

On Wed, Dec 2, 2015 at 1:00 AM, David Miller <davem@davemloft.net> wrote:
> From: Sunil Kovvuri <sunil.kovvuri@gmail.com>
> Date: Tue, 1 Dec 2015 22:00:49 +0530
>
>> Increasing descriptor ring size will lead to more memory allocation.
>> And what you are seeing is a memory alloc failure and doesn't seem
>> to be due to this driver change.  I mean it looks like the behavior
>> will be same for other drivers as well.
>
> The driver should successfully recover from out of memory situations
> and not stop RX/TX completely.
>
> There might be some other problem with your driver causing this.
>
> Don't put this off as not "related" to your patch, it is as this
> introduces the behavior for this user, and you should fix it before
> expecting me to apply this patch series.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 3/6] net: thunderx: Increase transmit queue length Sunil Goutham <sunil.kovvuri@gmail.com> - 2015-12-01 10:20 +0100
  RE: [PATCH 3/6] net: thunderx: Increase transmit queue length Pavel Fedin <p.fedin@samsung.com> - 2015-12-01 15:50 +0100
    Re: [PATCH 3/6] net: thunderx: Increase transmit queue length Eric Dumazet <eric.dumazet@gmail.com> - 2015-12-01 16:40 +0100
      Re: [PATCH 3/6] net: thunderx: Increase transmit queue length Sunil Kovvuri <sunil.kovvuri@gmail.com> - 2015-12-01 17:40 +0100
        Re: [PATCH 3/6] net: thunderx: Increase transmit queue length David Miller <davem@davemloft.net> - 2015-12-01 20:40 +0100
          Re: [PATCH 3/6] net: thunderx: Increase transmit queue length Sunil Kovvuri <sunil.kovvuri@gmail.com> - 2015-12-02 06:50 +0100
            Re: [PATCH 3/6] net: thunderx: Increase transmit queue length Eric Dumazet <eric.dumazet@gmail.com> - 2015-12-02 14:30 +0100
              Re: [PATCH 3/6] net: thunderx: Increase transmit queue length Eric Dumazet <eric.dumazet@gmail.com> - 2015-12-02 18:00 +0100
              Re: [PATCH 3/6] net: thunderx: Increase transmit queue length Sunil Kovvuri <sunil.kovvuri@gmail.com> - 2015-12-02 18:00 +0100
            Re: [PATCH 3/6] net: thunderx: Increase transmit queue length David Miller <davem@davemloft.net> - 2015-12-02 18:40 +0100
        RE: [PATCH 3/6] net: thunderx: Increase transmit queue length Pavel Fedin <p.fedin@samsung.com> - 2015-12-02 10:10 +0100
          RE: [PATCH 3/6] net: thunderx: Increase transmit queue length Pavel Fedin <p.fedin@samsung.com> - 2015-12-02 11:40 +0100
            RE: [PATCH 3/6] net: thunderx: Increase transmit queue length Pavel Fedin <p.fedin@samsung.com> - 2015-12-02 13:30 +0100
              Re: [PATCH 3/6] net: thunderx: Increase transmit queue length Sunil Kovvuri <sunil.kovvuri@gmail.com> - 2015-12-02 14:00 +0100
                RE: [PATCH 3/6] net: thunderx: Increase transmit queue length Pavel Fedin <p.fedin@samsung.com> - 2015-12-02 14:30 +0100
      RE: [PATCH 3/6] net: thunderx: Increase transmit queue length Pavel Fedin <p.fedin@samsung.com> - 2015-12-02 09:10 +0100

csiph-web