Re: cpuset: return -EINVAL for legacy non-subset child creation attempt

From	Mike Galbraith <efault@gmx.de>
Newsgroups	linux.kernel
Subject	Re: cpuset: return -EINVAL for legacy non-subset child creation attempt
Date	2015-12-02 04:30 +0100
Message-ID	<qB6hb-1Ij-1@gated-at.bofh.it> (permalink)
References	<qAV2q-2WT-17@gated-at.bofh.it> <qB4p3-ui-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, 2015-12-02 at 09:20 +0800, Zefan Li wrote:
> On 2015/12/1 23:22, Mike Galbraith wrote:
> > A legacy hierarchy child set that is not a subset of its parent is not
> > a permissions issue, it's an invalid configuration.  Return -EINVAL.
> >
> 
> It's sometimes arguable which errno should be used. In this case I don't
> see why we can't use EACCES. It's even documented in man page.
> 
>         EACCES Attempted to add, using write(2), a CPU  or  memory  node  to  a
>                cpuset, when that CPU or memory node was not already in its par-
>                ent.
> 
> Let's see another example. In mmap manual:
> 
> 	EACCES A  file descriptor refers to a non-regular file.
> 
> We can argue fd of a non-regular file is an invalid configuration, but
> here we return EACCES.

Ok, works for me (official -ENOPE -> gripee), thanks.

	-Mike

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

cpuset: return -EINVAL for legacy non-subset child creation attempt Mike Galbraith <efault@gmx.de> - 2015-12-01 16:30 +0100
  Re: cpuset: return -EINVAL for legacy non-subset child creation  attempt Zefan Li <lizefan@huawei.com> - 2015-12-02 02:30 +0100
    Re: cpuset: return -EINVAL for legacy non-subset child creation  attempt Mike Galbraith <efault@gmx.de> - 2015-12-02 04:30 +0100

csiph-web