Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1281413

Re: [PATCH 3/4] x86: Add trace point for MSR accesses

From Steven Rostedt <rostedt@goodmis.org>
Newsgroups linux.kernel
Subject Re: [PATCH 3/4] x86: Add trace point for MSR accesses
Date 2015-12-02 03:10 +0100
Message-ID <qB51L-XZ-5@gated-at.bofh.it> (permalink)
References <qB45H-ml-3@gated-at.bofh.it> <qB45H-ml-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Tue,  1 Dec 2015 17:00:59 -0800
Andi Kleen <andi@firstfloor.org> wrote:

> From: Andi Kleen <ak@linux.intel.com>
> 
> For debugging low level code interacting with the CPU
> it is often useful to trace the MSR read/writes. This gives
> a concise summary of PMU and other operations.
> 
> perf has an ad-hoc way to do this using trace_printk,
> but it's somewhat limited (and also now spews ugly boot
> messages when enabled)
> 
> Instead define real trace points for all MSR accesses.
> 
> This adds three new trace points: read_msr and write_msr
> and rdpmc.
> 
> They also report if the access faulted (if *_safe is used)
> 
> This allows filtering and triggering on specific
> MSR values, which allows various more advanced
> debugging techniques.
> 
> All the values are well defined in the CPU documentation.
> 
> The trace can be post processed with
> Documentation/trace/postprocess/decode_msr.py
> to add symbolic MSR names to the trace.
> 
> I only added it to native MSR accesses in C, not paravirtualized
> or in entry*.S (which is not too interesting)
> 
> Originally the patch kit moved the MSRs out of line.
> This uses an alternative approach recommended by Steven Rostedt
> of only moving the trace calls out of line, but open coding the
> access to the jump label.
> 
> v2:
> Move MSR trace events to arch/x86/include/asm/msr-trace.h
> Signed-off-by: Andi Kleen <ak@linux.intel.com>
>

For the general tracing part.

Acked-by: Steven Rostedt <rostedt@goodmis.org>

-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 3/4] x86: Add trace point for MSR accesses Andi Kleen <andi@firstfloor.org> - 2015-12-02 02:10 +0100
  Re: [PATCH 3/4] x86: Add trace point for MSR accesses Steven Rostedt <rostedt@goodmis.org> - 2015-12-02 03:10 +0100
  [tip:perf/core] x86, tracing, perf:   Add trace point for MSR accesses tip-bot for Andi Kleen <tipbot@zytor.com> - 2015-12-04 13:10 +0100
    Re: [tip:perf/core] x86, tracing, perf: Add trace point for MSR  accesses Borislav Petkov <bp@alien8.de> - 2015-12-04 13:20 +0100
      Re: [tip:perf/core] x86, tracing, perf: Add trace point for MSR  accesses Andi Kleen <ak@linux.intel.com> - 2015-12-04 19:30 +0100
        Re: [tip:perf/core] x86, tracing, perf: Add trace point for MSR  accesses Borislav Petkov <bp@alien8.de> - 2015-12-04 19:40 +0100
          Re: [tip:perf/core] x86, tracing, perf: Add trace point for MSR  accesses Andi Kleen <ak@linux.intel.com> - 2015-12-04 23:20 +0100
            Re: [tip:perf/core] x86, tracing, perf: Add trace point for MSR  accesses Borislav Petkov <bp@alien8.de> - 2015-12-04 23:30 +0100
          Re: [tip:perf/core] x86, tracing, perf: Add trace point for MSR accesses "H. Peter Anvin" <hpa@zytor.com> - 2015-12-04 23:40 +0100
            Re: [tip:perf/core] x86, tracing, perf: Add trace point for MSR  accesses Borislav Petkov <bp@alien8.de> - 2015-12-04 23:50 +0100
              Re: [tip:perf/core] x86, tracing, perf: Add trace point for MSR accesses "H. Peter Anvin" <hpa@zytor.com> - 2015-12-05 00:00 +0100
  [tip:perf/core] x86, tracing, perf:   Add trace point for MSR accesses tip-bot for Andi Kleen <tipbot@zytor.com> - 2015-12-06 14:30 +0100

csiph-web