Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1281411

Re: [PATCH 2/4] tracepoints: Move struct tracepoint to new tracepoint-defs.h header

Show all headers | View raw

On Tue,  1 Dec 2015 17:00:58 -0800
Andi Kleen <andi@firstfloor.org> wrote:

> From: Andi Kleen <ak@linux.intel.com>
> 
> Steven recommended open coding access to tracepoint->key to add
> trace points to headers. Unfortunately this is difficult for some
> headers (such as x86 asm/msr.h) because including tracepoint.h
> includes so many other headers that it causes include loops.
> The main problem is the include of linux/rcupdate.h, which
> pulls in a lot of other headers. The rcu header is only needed
> when actually defining trace points.
> 
> Move the struct tracepoint into a separate tracepoint-defs.h
> header that can be included without pulling in all of RCU.
> 
> Signed-off-by: Andi Kleen <ak@linux.intel.com>

Acked-by: Steven Rostedt <rostedt@goodmis.org>

-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/4] x86: Don't include asm/processor.h into asm/atomic.h Andi Kleen <andi@firstfloor.org> - 2015-12-02 02:10 +0100
  [PATCH 2/4] tracepoints: Move struct tracepoint to new tracepoint-defs.h header Andi Kleen <andi@firstfloor.org> - 2015-12-02 02:10 +0100
    Re: [PATCH 2/4] tracepoints: Move struct tracepoint to new  tracepoint-defs.h header Steven Rostedt <rostedt@goodmis.org> - 2015-12-02 03:00 +0100
    [tip:perf/core] tracepoints:   Move struct tracepoint to new tracepoint-defs.h header tip-bot for Andi Kleen <tipbot@zytor.com> - 2015-12-04 13:10 +0100
    [tip:perf/core] tracepoints:   Move struct tracepoint to new tracepoint-defs.h header tip-bot for Andi Kleen <tipbot@zytor.com> - 2015-12-06 14:20 +0100
  [PATCH 4/4] perf, x86: Remove old MSR perf tracing code Andi Kleen <andi@firstfloor.org> - 2015-12-02 02:10 +0100
    [tip:perf/core] perf/x86: Remove old MSR perf tracing code tip-bot for Andi Kleen <tipbot@zytor.com> - 2015-12-04 13:10 +0100
    [tip:perf/core] perf/x86: Remove old MSR perf tracing code tip-bot for Andi Kleen <tipbot@zytor.com> - 2015-12-06 14:30 +0100
  [tip:perf/core] x86/headers: Don't include asm/processor.h in asm  /atomic.h tip-bot for Andi Kleen <tipbot@zytor.com> - 2015-12-04 13:00 +0100
  [tip:perf/core] x86/headers: Don't include asm/processor.h in asm  /atomic.h tip-bot for Andi Kleen <tipbot@zytor.com> - 2015-12-06 14:20 +0100

csiph-web