Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1281332

[RFC] Add gup trace points support

Show all headers | View raw

Some background about why I think this might be useful.

When I was profiling some hugetlb related program, I got page-faults event
doubled when hugetlb is enabled. When I looked into the code, I found page-faults
come from two places, do_page_fault and gup. So, I tried to figure out which
play a role (or both) in my use case. But I can't find existing finer tracing
event for sub page-faults in current mainline kernel.

So, I added the gup trace points support to have finer tracing events for
page-faults. The below events are added:

__get_user_pages
__get_user_pages_fast
fixup_user_fault

Both __get_user_pages and fixup_user_fault call handle_mm_fault.

Just added trace points to raw version __get_user_pages since all variants
will call it finally to do real work.

Although __get_user_pages_fast doesn't call handle_mm_fault, it might be useful
to have it to distinguish between slow and fast version.


Yang Shi (7):
      trace/events: Add gup trace events
      mm/gup: add gup trace points
      x86: mm/gup: add gup trace points
      mips: mm/gup: add gup trace points
      s390: mm/gup: add gup trace points
      sh: mm/gup: add gup trace points
      sparc64: mm/gup: add gup trace points

 arch/mips/mm/gup.c         |  7 +++++++
 arch/s390/mm/gup.c         |  7 +++++++
 arch/sh/mm/gup.c           |  8 ++++++++
 arch/sparc/mm/gup.c        |  8 ++++++++
 arch/x86/mm/gup.c          |  7 +++++++
 include/trace/events/gup.h | 77 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 mm/gup.c                   |  8 ++++++++
 7 files changed, 122 insertions(+)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[RFC] Add gup trace points support Yang Shi <yang.shi@linaro.org> - 2015-12-02 00:30 +0100
  [PATCH 1/7] trace/events: Add gup trace events Yang Shi <yang.shi@linaro.org> - 2015-12-02 00:30 +0100
    Re: [PATCH 1/7] trace/events: Add gup trace events Steven Rostedt <rostedt@goodmis.org> - 2015-12-02 01:00 +0100
      Re: [PATCH 1/7] trace/events: Add gup trace events "Shi, Yang" <yang.shi@linaro.org> - 2015-12-02 01:10 +0100
        Re: [PATCH 1/7] trace/events: Add gup trace events Steven Rostedt <rostedt@goodmis.org> - 2015-12-02 01:20 +0100
          Re: [PATCH 1/7] trace/events: Add gup trace events "Shi, Yang" <yang.shi@linaro.org> - 2015-12-02 01:40 +0100
  [PATCH 4/7] mips: mm/gup: add gup trace points Yang Shi <yang.shi@linaro.org> - 2015-12-02 00:30 +0100
    Re: [PATCH 4/7] mips: mm/gup: add gup trace points Ralf Baechle <ralf@linux-mips.org> - 2015-12-02 14:30 +0100

csiph-web