Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1281364

Re: [PATCH 3/6] Input: Update vmmouse.c to use the common VMW_PORT macros

Path csiph.com!goblin2!goblin.stu.neva.ru!gothmog.csi.it!bofh.it!news.nic.it!robomod
From Dmitry Torokhov <dmitry.torokhov@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH 3/6] Input: Update vmmouse.c to use the common VMW_PORT macros
Date Wed, 02 Dec 2015 01:00:03 +0100
Message-ID <qB2ZZ-7VO-33@gated-at.bofh.it> (permalink)
References <qB1rb-76P-3@gated-at.bofh.it> <qB1rb-76P-5@gated-at.bofh.it> <qB1rb-76P-7@gated-at.bofh.it> <qB1AR-79P-1@gated-at.bofh.it> <qB1Ky-7cT-13@gated-at.bofh.it> <qB1Ue-7g2-9@gated-at.bofh.it> <qB23T-7jj-5@gated-at.bofh.it>
X-Original-To Sinclair Yeh <syeh@vmware.com>
Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=H80ls6h9b1C7kwrFBGd9TLBnCqU09Nip7sGW6m1XF64=; b=OdO8NhDEV4X5fJNF+K4Vt3Upws8fz5+S6zMWxsNPLnKuKK5q3Wcqh3b4ksz85w7S+y NWed/8u4UErG0EwFwqkNSYJqPY+MFETk2cC7RzguKnBNQKIysC5+KnNZWf3k13w3uc4O h6iOVL4vZ+evfygeCeX2T9PSmxOR0DOl7sBn0MKZycZpCkPhCiH8XpAFOj/ADiYr7wKM ks/Vddq4j+fY7zic4yaGsZ4irkEbTIuRGhDAgTAV8Ym+Xw5OgcoQi8+7VTk7qcDbD4WK WVrx3NfLXOnFAkK1PnsjBl/J8aZVOnGdf6XQ6YJpODGejp9dgVLMIo3yuv4h7ZIbBj6m X3ow==
MIME-Version 1.0
X-Received by 10.202.239.138 with SMTP id n132mr136584oih.88.1449014199901; Tue, 01 Dec 2015 15:56:39 -0800 (PST)
Content-Type text/plain; charset=UTF-8
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 65
Organization linux.* mail to news gateway
X-Original-Cc X86 ML <x86@kernel.org>, "pv-drivers@vmware.com" <pv-drivers@vmware.com>, "linux-graphics-maintainer@vmware.com" <linux-graphics-maintainer@vmware.com>, Arnd Bergmann <arnd@arndb.de>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, lkml <linux-kernel@vger.kernel.org>, virtualization@lists.linux-foundation.org, "linux-input@vger.kernel.org" <linux-input@vger.kernel.org>
X-Original-Date Tue, 1 Dec 2015 15:56:39 -0800
X-Original-Message-ID <CAKdAkRThOqXpVPYbSTE305_6=sOK8Kfbxfof_ybvJxvm4ge9Kg@mail.gmail.com>
X-Original-References <1449008047-8252-1-git-send-email-syeh@vmware.com> <1449008332-9394-1-git-send-email-syeh@vmware.com> <1449008332-9394-3-git-send-email-syeh@vmware.com> <20151201222414.GH3740@dtor-ws> <20151201223255.GA10753@syeh-linux> <CAKdAkRTVJ_DWD6uYhp+qd1uYwe3rPguDFAMXpa5=8CwVuO16NQ@mail.gmail.com> <20151201225420.GA11210@syeh-linux>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1281364

Show key headers only | View raw

On Tue, Dec 1, 2015 at 2:54 PM, Sinclair Yeh <syeh@vmware.com> wrote:
> Hi,
>
> On Tue, Dec 01, 2015 at 02:45:27PM -0800, Dmitry Torokhov wrote:
>> On Tue, Dec 1, 2015 at 2:32 PM, Sinclair Yeh <syeh@vmware.com> wrote:
>> > Hi,
>> >
>
> <snip>
>
>> >> >   */
>> >> > -#define VMMOUSE_CMD(cmd, in1, out1, out2, out3, out4)      \
>> >> > -({                                                 \
>> >> > -   unsigned long __dummy1, __dummy2;               \
>> >> > -   __asm__ __volatile__ ("inl %%dx" :              \
>> >> > -           "=a"(out1),                             \
>> >> > -           "=b"(out2),                             \
>> >> > -           "=c"(out3),                             \
>> >> > -           "=d"(out4),                             \
>> >> > -           "=S"(__dummy1),                         \
>> >> > -           "=D"(__dummy2) :                        \
>> >> > -           "a"(VMMOUSE_PROTO_MAGIC),               \
>> >> > -           "b"(in1),                               \
>> >> > -           "c"(VMMOUSE_PROTO_CMD_##cmd),           \
>> >> > -           "d"(VMMOUSE_PROTO_PORT) :               \
>> >> > -           "memory");                              \
>> >> > +#define VMMOUSE_CMD(cmd, in1, out1, out2, out3, out4)                 \
>> >> > +({                                                            \
>> >> > +   unsigned long __dummy1 = 0, __dummy2 = 0;                  \
>> >>
>> >> Why do we need to initialize dummies?
>> >
>> > Because for some commands those parameters to VMW_PORT() can be both
>> > input and outout.
>>
>> The vmmouse commands do not use them as input though, so it seems we
>> are simply wasting CPU cycles setting them to 0 just because we are
>> using the new VMW_PORT here. Why do we need to switch? What is the
>> benefit of doing this?
>
> There are two reasons.  One is to make the code more readable and
> maintainable.  Rather than having mostly similar inline assembly
> code sprinkled across multiple modules, we can just use the macros
> and document that.

At the cost of wasting cycles though :(.

Oh well, it is not like we are polling the backdoor here, so if you do
not care about a few wasted cycles I don't have to either ;)

>
> The second reason is this organization makes some on-going future
> development easier.
>
> Hope this helps.
>
> Sinclair

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 3/6] Input: Update vmmouse.c to use the common VMW_PORT macros "Sinclair Yeh" <syeh@vmware.com> - 2015-12-01 23:20 +0100
  Re: [PATCH 3/6] Input: Update vmmouse.c to use the common VMW_PORT  macros Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2015-12-01 23:30 +0100
    Re: [PATCH 3/6] Input: Update vmmouse.c to use the common VMW_PORT  macros "Sinclair Yeh" <syeh@vmware.com> - 2015-12-01 23:40 +0100
      Re: [PATCH 3/6] Input: Update vmmouse.c to use the common VMW_PORT macros Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2015-12-01 23:50 +0100
        Re: [PATCH 3/6] Input: Update vmmouse.c to use the common VMW_PORT  macros "Sinclair Yeh" <syeh@vmware.com> - 2015-12-02 00:00 +0100
          Re: [PATCH 3/6] Input: Update vmmouse.c to use the common VMW_PORT macros Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2015-12-02 01:00 +0100
          Re: [PATCH 3/6] Input: Update vmmouse.c to use the common VMW_PORT  macros Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2015-12-02 01:10 +0100
            Re: [PATCH 3/6] Input: Update vmmouse.c to use the common VMW_PORT  macros "Sinclair Yeh" <syeh@vmware.com> - 2015-12-02 03:20 +0100
              Re: [PATCH 3/6] Input: Update vmmouse.c to use the common VMW_PORT  macros Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2015-12-02 16:40 +0100
                Re: [PATCH 3/6] Input: Update vmmouse.c to use the common VMW_PORT  macros "Sinclair Yeh" <syeh@vmware.com> - 2015-12-02 17:00 +0100
                Re: [Linux-graphics-maintainer] [PATCH 3/6] Input: Update vmmouse.c  to use the common VMW_PORT macros Thomas Hellstrom <thellstrom@vmware.com> - 2015-12-02 18:30 +0100
                Re: [PATCH 3/6] Input: Update vmmouse.c to use the common VMW_PORT  macros Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2015-12-02 18:30 +0100
                Re: [PATCH 3/6] Input: Update vmmouse.c to use the common VMW_PORT  macros Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2015-12-02 19:50 +0100
                Re: [PATCH 3/6] Input: Update vmmouse.c to use the common VMW_PORT  macros Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2015-12-02 20:00 +0100
                Re: [PATCH 3/6] Input: Update vmmouse.c to use the common VMW_PORT  macros "Sinclair Yeh" <syeh@vmware.com> - 2015-12-02 20:10 +0100
            Re: [Linux-graphics-maintainer] [PATCH 3/6] Input: Update vmmouse.c  to use the common VMW_PORT macros Thomas Hellstrom <thellstrom@vmware.com> - 2015-12-02 08:10 +0100
  Re: [PATCH 3/6] Input: Update vmmouse.c to use the common VMW_PORT  macros Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2015-12-02 01:10 +0100

csiph-web