Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1281351

[PATCH 05/10] ARM: OMAP2+: Disable GPIO softreset for dm81xx

Show all headers | View raw

Looks like GPIO softreset status bit on both dm8168 and dm8148
is broken and only goes high initially. After writing to sysc
softreset bit, the resetdone bit never goes high again.

I noticed this as GPIOs are enabled from u-boot at least on t410.
And this can be tested easliy with the following commands in u-boot:

# mw.l 0x4818155c 0x2
# md.l 0x48032114 1
48032114: 00000001    ....
# mw.l 0x48032010 0x2
# md.l 0x48032114 1
48032114: 00000000    ....

Looks like the GPIO module is functional even with the resetdone
bit down.

Let's just tag the GPIOs for dm81xx with HWMOD_INIT_NO_RESET.

Cc: Paul Walmsley <paul@pwsan.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>
---
 arch/arm/mach-omap2/omap_hwmod_81xx_data.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/arm/mach-omap2/omap_hwmod_81xx_data.c b/arch/arm/mach-omap2/omap_hwmod_81xx_data.c
index 1b96cdf..440fd6c 100644
--- a/arch/arm/mach-omap2/omap_hwmod_81xx_data.c
+++ b/arch/arm/mach-omap2/omap_hwmod_81xx_data.c
@@ -432,6 +432,7 @@ static struct omap_hwmod_ocp_if dm81xx_l4_ls__elm = {
 	.user		= OCP_USER_MPU,
 };
 
+/* On dm81xx RESETDONE bit seems to never goes high again after SOFTRESET */
 static struct omap_hwmod_class_sysconfig dm81xx_gpio_sysc = {
 	.rev_offs	= 0x0000,
 	.sysc_offs	= 0x0010,
@@ -463,6 +464,7 @@ static struct omap_hwmod dm81xx_gpio1_hwmod = {
 	.name		= "gpio1",
 	.clkdm_name	= "alwon_l3s_clkdm",
 	.class		= &dm81xx_gpio_hwmod_class,
+	.flags		= HWMOD_INIT_NO_RESET,
 	.main_clk	= "sysclk6_ck",
 	.prcm = {
 		.omap4 = {
@@ -490,6 +492,7 @@ static struct omap_hwmod dm81xx_gpio2_hwmod = {
 	.clkdm_name	= "alwon_l3s_clkdm",
 	.class		= &dm81xx_gpio_hwmod_class,
 	.main_clk	= "sysclk6_ck",
+	.flags		= HWMOD_INIT_NO_RESET,
 	.prcm = {
 		.omap4 = {
 			.clkctrl_offs = DM81XX_CM_ALWON_GPIO_1_CLKCTRL,
-- 
2.6.2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 00/10] Patches to get dm814x-evm booting to NFSroot Tony Lindgren <tony@atomide.com> - 2015-12-02 00:40 +0100
  [PATCH 02/10] clk: ti: Add few dm814x clock aliases Tony Lindgren <tony@atomide.com> - 2015-12-02 00:40 +0100
    Re: [PATCH 02/10] clk: ti: Add few dm814x clock aliases Tony Lindgren <tony@atomide.com> - 2015-12-08 18:00 +0100
      Re: [PATCH 02/10] clk: ti: Add few dm814x clock aliases Tero Kristo <t-kristo@ti.com> - 2015-12-08 20:30 +0100
        Re: [PATCH 02/10] clk: ti: Add few dm814x clock aliases Tony Lindgren <tony@atomide.com> - 2015-12-08 21:20 +0100
          Re: [PATCH 02/10] clk: ti: Add few dm814x clock aliases Tero Kristo <t-kristo@ti.com> - 2015-12-09 09:00 +0100
            Re: [PATCH 02/10] clk: ti: Add few dm814x clock aliases Tony Lindgren <tony@atomide.com> - 2015-12-10 02:00 +0100
  [PATCH 05/10] ARM: OMAP2+: Disable GPIO softreset for dm81xx Tony Lindgren <tony@atomide.com> - 2015-12-02 00:50 +0100
    Re: [PATCH 05/10] ARM: OMAP2+: Disable GPIO softreset for dm81xx Matthijs van Duin <matthijsvanduin@gmail.com> - 2015-12-02 01:20 +0100
      Re: [PATCH 05/10] ARM: OMAP2+: Disable GPIO softreset for dm81xx Tony Lindgren <tony@atomide.com> - 2015-12-02 01:50 +0100
        Re: [PATCH 05/10] ARM: OMAP2+: Disable GPIO softreset for dm81xx Tony Lindgren <tony@atomide.com> - 2015-12-02 02:00 +0100
          Re: [PATCH 05/10] ARM: OMAP2+: Disable GPIO softreset for dm81xx Tony Lindgren <tony@atomide.com> - 2015-12-02 02:40 +0100
  [PATCH 08/10] ARM: dts: Fix some mux and divider clocks to get dm814x-evm booting Tony Lindgren <tony@atomide.com> - 2015-12-02 00:50 +0100
  Re: [PATCH 00/10] Patches to get dm814x-evm booting to NFSroot Grygorii Strashko <grygorii.strashko@ti.com> - 2015-12-03 19:20 +0100
    Re: [PATCH 00/10] Patches to get dm814x-evm booting to NFSroot Tony Lindgren <tony@atomide.com> - 2015-12-03 20:30 +0100

csiph-web