Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1281265

Re: [PATCH v1] mm: fix warning in comparing enumerator

Show key headers only | View raw

On Tue, 1 Dec 2015, Naoya Horiguchi wrote:

> I saw the following warning when building mmotm-2015-11-25-17-08.
> 
> mm/page_alloc.c:4185:16: warning: comparison between 'enum zone_type' and 'enum <anonymous>' [-Wenum-compare]
>   for (i = 0; i < MAX_ZONELISTS; i++) {
>                 ^
> 
> enum zone_type is named like ZONE_* which is different from ZONELIST_*, so
> we are somehow doing incorrect comparison. Just fixes it.
> 
> Signed-off-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
> ---
>  mm/page_alloc.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git mmotm-2015-11-25-17-08/mm/page_alloc.c mmotm-2015-11-25-17-08_patched/mm/page_alloc.c
> index e267faa..b801e6f 100644
> --- mmotm-2015-11-25-17-08/mm/page_alloc.c
> +++ mmotm-2015-11-25-17-08_patched/mm/page_alloc.c
> @@ -4174,8 +4174,7 @@ static void set_zonelist_order(void)
>  
>  static void build_zonelists(pg_data_t *pgdat)
>  {
> -	int j, node, load;
> -	enum zone_type i;
> +	int i, j, node, load;
>  	nodemask_t used_mask;
>  	int local_node, prev_node;
>  	struct zonelist *zonelist;

Obviously correct, but I would have thought we could just remove 'j' and 
used 'i' as our iterator through the entire function.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v1] mm: fix warning in comparing enumerator Naoya Horiguchi <n-horiguchi@ah.jp.nec.com> - 2015-12-01 09:40 +0100
  Re: [PATCH v1] mm: fix warning in comparing enumerator David Rientjes <rientjes@google.com> - 2015-12-01 23:30 +0100
    [PATCH v2] mm: fix warning in comparing enumerator Naoya Horiguchi <nao.horiguchi@gmail.com> - 2015-12-02 00:20 +0100
      Re: [PATCH v2] mm: fix warning in comparing enumerator David Rientjes <rientjes@google.com> - 2015-12-02 00:40 +0100
      Re: [PATCH v2] mm: fix warning in comparing enumerator Yaowei Bai <baiyaowei@cmss.chinamobile.com> - 2015-12-02 10:20 +0100

csiph-web