Re: [PATCH 7/8] cgroup: mount cgroupns-root when inside non-init cgroupns

From	"Serge E. Hallyn" <serge.hallyn@ubuntu.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 7/8] cgroup: mount cgroupns-root when inside non-init cgroupns
Date	2015-12-01 23:00 +0100
Message-ID	<qB17Q-6L3-11@gated-at.bofh.it> (permalink)
References	(2 earlier) <qypq1-2Eg-9@gated-at.bofh.it> <qzjBT-6SA-5@gated-at.bofh.it> <qAyfv-5eb-19@gated-at.bofh.it> <qAKql-4CV-5@gated-at.bofh.it> <qAWhQ-3F3-27@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Dec 01, 2015 at 11:46:49AM -0500, Tejun Heo wrote:
> Hey, Serge.
> 
> On Mon, Nov 30, 2015 at 10:07:04PM -0600, Serge E. Hallyn wrote:
> > So actually the way the code is now, the first mount cannot
> > be done from a non-init user namespace; and kernfs_obtain_root()
> > is only called from non-init user namespace.  So can we assume
> > that the root dentry will be instantiated?  (or can it get
> > evicted?)
> > 
> > If we can assume that then most of that fn can go away.
> 
> The v2 hierarchy is always mounted and non-init ns shouldn't be able
> to create new v1 hierarchies, so the root dentry should always be
> there.

I mispoke before though - it's not the hierarchy's root dentry,
but rather a dentry for a descendent cgroup which will become the
root dentry for the new superblock.  We do know that there must be
a css_set with a cgroup.  I'm still trying to track down whether
that cgrou's inode's dentry can ever be flushed.  I would think
not but am not sure.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

Re: [PATCH 7/8] cgroup: mount cgroupns-root when inside non-init  cgroupns "Serge E. Hallyn" <serge.hallyn@ubuntu.com> - 2015-12-01 05:10 +0100
  Re: [PATCH 7/8] cgroup: mount cgroupns-root when inside non-init  cgroupns Tejun Heo <tj@kernel.org> - 2015-12-01 17:50 +0100
    Re: [PATCH 7/8] cgroup: mount cgroupns-root when inside non-init  cgroupns "Serge E. Hallyn" <serge.hallyn@ubuntu.com> - 2015-12-01 23:00 +0100
      Re: [PATCH 7/8] cgroup: mount cgroupns-root when inside non-init  cgroupns Tejun Heo <tj@kernel.org> - 2015-12-02 18:00 +0100
        Re: [PATCH 7/8] cgroup: mount cgroupns-root when inside non-init  cgroupns Tejun Heo <tj@kernel.org> - 2015-12-02 18:10 +0100
          Re: [PATCH 7/8] cgroup: mount cgroupns-root when inside non-init  cgroupns "Serge E. Hallyn" <serge.hallyn@ubuntu.com> - 2015-12-03 23:50 +0100
            Re: [PATCH 7/8] cgroup: mount cgroupns-root when inside non-init  cgroupns Tejun Heo <tj@kernel.org> - 2015-12-07 16:40 +0100
              Re: [PATCH 7/8] cgroup: mount cgroupns-root when inside non-init  cgroupns Serge Hallyn <serge.hallyn@ubuntu.com> - 2015-12-07 17:00 +0100
        Re: [PATCH 7/8] cgroup: mount cgroupns-root when inside non-init  cgroupns "Serge E. Hallyn" <serge.hallyn@ubuntu.com> - 2015-12-02 18:10 +0100
      Re: [PATCH 7/8] cgroup: mount cgroupns-root when inside non-init  cgroupns "Serge E. Hallyn" <serge.hallyn@ubuntu.com> - 2015-12-02 18:00 +0100
      Re: [PATCH 7/8] cgroup: mount cgroupns-root when inside non-init  cgroupns Tejun Heo <tj@kernel.org> - 2015-12-02 18:00 +0100

csiph-web