[PATCH 08/28] PCI: xilinx: fix INTX irq dispatch

Path	csiph.com!news.mixmin.net!weretis.net!feeder4.news.weretis.net!storethat.news.telefonica.de!telefonica.de!news.panservice.it!bofh.it!news.nic.it!robomod
From	Paul Burton <paul.burton@imgtec.com>
Newsgroups	linux.kernel
Subject	[PATCH 08/28] PCI: xilinx: fix INTX irq dispatch
Date	Mon, 30 Nov 2015 17:30:03 +0100
Message-ID	<qAzuX-5YC-43@gated-at.bofh.it> (permalink)
References	<qAzuW-5YC-3@gated-at.bofh.it>
X-Original-To	<linux-mips@linux-mips.org>
X-Mailer	git-send-email 2.6.2
MIME-Version	1.0
Content-Type	text/plain
X-Originating-IP	[10.100.200.236]
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	35
Organization	linux.* mail to news gateway
X-Original-Cc	Paul Burton <paul.burton@imgtec.com>, Sören Brinkmann <soren.brinkmann@xilinx.com>, Michal Simek <michal.simek@xilinx.com>, "Jiang Liu" <jiang.liu@linux.intel.com>, Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>, Rob Herring <robh@kernel.org>, Bjorn Helgaas <bhelgaas@google.com>, <linux-pci@vger.kernel.org>, Russell Joyce <russell.joyce@york.ac.uk>, <linux-kernel@vger.kernel.org>, Jingoo Han <jingoohan1@gmail.com>, <linux-arm-kernel@lists.infradead.org>
X-Original-Date	Mon, 30 Nov 2015 16:21:33 +0000
X-Original-Message-ID	<1448900513-20856-9-git-send-email-paul.burton@imgtec.com>
X-Original-References	<1448900513-20856-1-git-send-email-paul.burton@imgtec.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1280074

Show key headers only | View raw

The IRQ domain for INTX interrupts has 4 entries, numbered 0 to 3. This
matches what the hardware reports from the interrupt FIFO exactly, but
xilinx_pcie_intr_handler was adding 1 to that value to convert to the
range 1 to 4. Stop adding 1, such that all of INTA through to INTD fall
within the range of the IRQ domain.

Signed-off-by: Paul Burton <paul.burton@imgtec.com>
---

 drivers/pci/host/pcie-xilinx.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/pci/host/pcie-xilinx.c b/drivers/pci/host/pcie-xilinx.c
index 3058a57..ac9da72 100644
--- a/drivers/pci/host/pcie-xilinx.c
+++ b/drivers/pci/host/pcie-xilinx.c
@@ -451,8 +451,8 @@ static irqreturn_t xilinx_pcie_intr_handler(int irq, void *data)
 			irq = pcie_read(port, XILINX_PCIE_REG_RPIFR2) &
 				XILINX_PCIE_RPIFR2_MSG_DATA;
 		} else {
-			val = ((val & XILINX_PCIE_RPIFR1_INTR_MASK) >>
-				XILINX_PCIE_RPIFR1_INTR_SHIFT) + 1;
+			val = (val & XILINX_PCIE_RPIFR1_INTR_MASK) >>
+				XILINX_PCIE_RPIFR1_INTR_SHIFT;
 			irq = irq_find_mapping(port->irq_domain, val);
 		}
 
-- 
2.6.2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH 08/28] PCI: xilinx: fix INTX irq dispatch Paul Burton <paul.burton@imgtec.com> - 2015-11-30 17:30 +0100

csiph-web