Re: [PATCH] ASoC: rsnd: fix a possible NULL dereference

From	Mark Brown <broonie@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] ASoC: rsnd: fix a possible NULL dereference
Date	2015-11-30 17:40 +0100
Message-ID	<qAzEC-62E-3@gated-at.bofh.it> (permalink)
References	<qyHPX-6p2-1@gated-at.bofh.it> <qyRZ0-4Aw-17@gated-at.bofh.it> <qyZ0u-1Eu-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Thu, Nov 26, 2015 at 08:17:15AM +0100, LABBE Corentin wrote:
> On Wed, Nov 25, 2015 at 11:46:45PM +0000, Kuninori Morimoto wrote:

> > > +	of_data = of_device_get_match_data(dev);
> > > +	if (!of_data)
> > > +		return 1;

> > return 1 ?
> > You want to use -EINVAL ?

> I do that Uwe Kleine-König said to me to do in others thread:
> https://lkml.org/lkml/2015/11/12/70 and https://lkml.org/lkml/2015/11/16/211

What error code to return is going to depend on the context - you need
to look at what the caller is expecting and how it will handle the value
returned.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] ASoC: rsnd: fix a possible NULL dereference LABBE Corentin <clabbe.montjoie@gmail.com> - 2015-11-25 14:00 +0100
  Re: [PATCH] ASoC: rsnd: fix a possible NULL dereference Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> - 2015-11-26 00:50 +0100
    Re: [PATCH] ASoC: rsnd: fix a possible NULL dereference LABBE Corentin <clabbe.montjoie@gmail.com> - 2015-11-26 08:20 +0100
      Re: [PATCH] ASoC: rsnd: fix a possible NULL dereference Mark Brown <broonie@kernel.org> - 2015-11-30 17:40 +0100

csiph-web