Re: [PATCH v2 3/9] includes: dt-bindings: Add STM32F429 pinctrl DT bindings

From	Maxime Coquelin <mcoquelin.stm32@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 3/9] includes: dt-bindings: Add STM32F429 pinctrl DT bindings
Date	2015-11-30 17:00 +0100
Message-ID	<qAz1U-5xV-9@gated-at.bofh.it> (permalink)
References	(2 earlier) <qlBfm-7L2-55@gated-at.bofh.it> <qlI78-Ns-29@gated-at.bofh.it> <qmnjY-2vq-27@gated-at.bofh.it> <qrOMy-4BZ-17@gated-at.bofh.it> <qvMj7-4ds-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

2015-11-17 12:00 GMT+01:00 Linus Walleij <linus.walleij@linaro.org>:
> On Fri, Nov 6, 2015 at 1:57 PM, Maxime Coquelin
> <mcoquelin.stm32@gmail.com> wrote:
>
>> Thinking again at it, I persist to believe have the defines makes it
>> easier to use.
>> With auto-completion, it makes it faster and less error prone to
>> select the right
>> alternate function without parsing the datasheet.
>
> Auto-completion ... should we design our source code to
> fit certain editors?
No, you are right.
But even without auto-completion, it is easier to have the values pre-computed.
And Mediatek has the defines, so it is better to do the same for STM32
for consistency.

>> But as these defines are not actually used on driver side, maybe I
>> could just move
>> them to the dts directory?
>
> No strong opinion there. include/dt-bindings is part of the bindings
> documentation actually so I guess it goes there.
Ok.

Thanks,
Maxime
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2 3/9] includes: dt-bindings: Add STM32F429 pinctrl DT bindings Linus Walleij <linus.walleij@linaro.org> - 2015-11-17 12:10 +0100
  Re: [PATCH v2 3/9] includes: dt-bindings: Add STM32F429 pinctrl DT bindings Maxime Coquelin <mcoquelin.stm32@gmail.com> - 2015-11-30 17:00 +0100

csiph-web