Re: [PATCH 1/3] gpio: 74xx: fix a possible NULL dereference

From	Linus Walleij <linus.walleij@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/3] gpio: 74xx: fix a possible NULL dereference
Date	2015-11-30 13:10 +0100
Message-ID	<qAvrk-3rH-11@gated-at.bofh.it> (permalink)
References	<qtKbL-7AZ-3@gated-at.bofh.it> <qwQb0-5kb-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Nov 20, 2015 at 10:22 AM, Geert Uytterhoeven
<geert@linux-m68k.org> wrote:
> On Wed, Nov 11, 2015 at 9:27 PM, LABBE Corentin
> <clabbe.montjoie@gmail.com> wrote:
>> of_match_device could return NULL, and so cause a NULL pointer
>> dereference later at line 132:
>> priv->flags = (uintptr_t) of_id->data;
>>
>> Reported-by: coverity (CID 1324141)
>
> This is a DT-only driver, hence this cannot happen?

Yeah I said the same in comment to some other patch in the
series. But it doesn't hurt much either. Coccinelle has no clue
about deeper semantics, just shallow semantics.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 1/3] gpio: 74xx: fix a possible NULL dereference Geert Uytterhoeven <geert@linux-m68k.org> - 2015-11-20 10:30 +0100
  Re: [PATCH 1/3] gpio: 74xx: fix a possible NULL dereference Linus Walleij <linus.walleij@linaro.org> - 2015-11-30 13:10 +0100

csiph-web