Re: [PATCH] tools/virtio: fix byteswap logic

From	Cornelia Huck <cornelia.huck@de.ibm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] tools/virtio: fix byteswap logic
Date	2015-11-30 11:10 +0100
Message-ID	<qAtzd-2de-17@gated-at.bofh.it> (permalink)
References	<qAsa7-1cU-29@gated-at.bofh.it>
Organization	IBM Deutschland Research & Development GmbH Vorsitzende des Aufsichtsrats: Martina Koederitz Geschäftsführung: Dirk Wittkopp Sitz der Gesellschaft: Böblingen Registergericht: Amtsgericht Stuttgart, HRB 243294

Show all headers | View raw

On Mon, 30 Nov 2015 10:33:34 +0200
"Michael S. Tsirkin" <mst@redhat.com> wrote:

> commit cf561f0d2eb74574ad9985a2feab134267a9d298 ("virtio: introduce
> virtio_is_little_endian() helper") changed byteswap logic to
> skip feature bit checks for LE platforms, but didn't
> update tools/virtio, so vring_bench started failing.
> 
> Update the copy under tools/virtio/ (TODO: find a way to avoid this code
> duplication).

Not to mention that it is easy to miss the code duplication...

> 
> Cc: Greg Kurz <gkurz@linux.vnet.ibm.com>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
>  tools/virtio/linux/virtio_config.h | 20 +++++++++++++-------
>  1 file changed, 13 insertions(+), 7 deletions(-)

Reviewed-by: Cornelia Huck <cornelia.huck@de.ibm.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH] tools/virtio: fix byteswap logic "Michael S. Tsirkin" <mst@redhat.com> - 2015-11-30 09:40 +0100
  Re: [PATCH] tools/virtio: fix byteswap logic Greg Kurz <gkurz@linux.vnet.ibm.com> - 2015-11-30 10:40 +0100
  Re: [PATCH] tools/virtio: fix byteswap logic Cornelia Huck <cornelia.huck@de.ibm.com> - 2015-11-30 11:10 +0100
  Re: [PATCH] tools/virtio: fix byteswap logic Venkatesh Srinivas <venkateshs@google.com> - 2015-12-04 20:50 +0100

csiph-web