Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1279739
| From | Masahiro Yamada <yamada.masahiro@socionext.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH 4/4] i2c: uniphier_f: error out if bus speed is zero |
| Date | 2015-11-30 11:00 +0100 |
| Message-ID | <qAtpw-1UE-7@gated-at.bofh.it> (permalink) |
| References | <qAtpv-1UE-1@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
There is code to divide by "bus_speed" some lines below.
To eliminate the possibility of division by zero, bail out if
"clock-frequency" is specified as zero.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---
drivers/i2c/busses/i2c-uniphier-f.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/i2c/busses/i2c-uniphier-f.c b/drivers/i2c/busses/i2c-uniphier-f.c
index 67109e1..f3e5ff8 100644
--- a/drivers/i2c/busses/i2c-uniphier-f.c
+++ b/drivers/i2c/busses/i2c-uniphier-f.c
@@ -466,6 +466,11 @@ static int uniphier_fi2c_clk_init(struct device *dev,
if (of_property_read_u32(np, "clock-frequency", &bus_speed))
bus_speed = UNIPHIER_FI2C_DEFAULT_SPEED;
+ if (!bus_speed) {
+ dev_err(dev, "clock-freqyency should not be zero\n");
+ return -EINVAL;
+ }
+
if (bus_speed > UNIPHIER_FI2C_MAX_SPEED)
bus_speed = UNIPHIER_FI2C_MAX_SPEED;
--
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/4] i2c: uniphier: add minor sanity checks to i2c-uniphier/i2c-uniphier-f Masahiro Yamada <yamada.masahiro@socionext.com> - 2015-11-30 11:00 +0100 [PATCH 2/4] i2c: uniphier: error out if bus speed is zero Masahiro Yamada <yamada.masahiro@socionext.com> - 2015-11-30 11:00 +0100 [PATCH 4/4] i2c: uniphier_f: error out if bus speed is zero Masahiro Yamada <yamada.masahiro@socionext.com> - 2015-11-30 11:00 +0100 [PATCH 3/4] i2c: uniphier_f: error out if clock rate is zero Masahiro Yamada <yamada.masahiro@socionext.com> - 2015-11-30 11:00 +0100
csiph-web