Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1279685

Re: [PATCH v2] ath6kl: Use vmalloc for loading firmware using api1 method and use kvfree

From Kalle Valo <kvalo@qca.qualcomm.com>
Newsgroups linux.kernel
Subject Re: [PATCH v2] ath6kl: Use vmalloc for loading firmware using api1 method and use kvfree
Date 2015-11-30 09:50 +0100
Message-ID <qAsjL-1hf-5@gated-at.bofh.it> (permalink)
References <qk5AR-4FE-3@gated-at.bofh.it> <qA2z0-1ZG-9@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Brent Taylor <motobud@gmail.com> writes:

> Signed-off-by: Brent Taylor <motobud@gmail.com>
>
> ath6kl: Use vmalloc for loading firmware using api1 method and free using kvfree
> ---
> Changes v1 -> v2:
>    - simplify memory allocation
>    - use kvfree

Why? The commit log should _always_ answer that. Are you fixing a bug
(what bug exactly?), is this just cleanup or what?

And the commit log is wrongly formatted anyway, the Signed-off-by line
should be the last and there should be no "ath6kl:" string in the commit
log (just in the title). Use 'git log' to find examples.

-- 
Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v2] ath6kl: Use vmalloc for loading firmware using api1 method and use kvfree Brent Taylor <motobud@gmail.com> - 2015-11-29 06:20 +0100
  Re: [PATCH v2] ath6kl: Use vmalloc for loading firmware using api1  method and use kvfree kbuild test robot <lkp@intel.com> - 2015-11-29 06:30 +0100
  [PATCH v3] ath6kl: Use vmalloc for loading firmware using api1 method and use kvfree Brent Taylor <motobud@gmail.com> - 2015-11-29 07:00 +0100
    Re: [PATCH v3] ath6kl: Use vmalloc for loading firmware using api1 method and use kvfree Kalle Valo <kvalo@qca.qualcomm.com> - 2015-11-30 09:50 +0100
  Re: [PATCH v2] ath6kl: Use vmalloc for loading firmware using api1 method and use kvfree Kalle Valo <kvalo@qca.qualcomm.com> - 2015-11-30 09:50 +0100
    Re: [PATCH v2] ath6kl: Use vmalloc for loading firmware using api1 method and use kvfree Kalle Valo <kvalo@qca.qualcomm.com> - 2015-11-30 10:10 +0100

csiph-web